Commit 7563a0b
Fix tutorials after introduction of MetricFetchResult (#1243)
Summary:
X-link: facebook/Ax#1243
Pull Request resolved: #1475
A few tutorials were not compatible with the new way we fetch data. In this diff we change custom metrics to return Ok(data) instead of data, and change `trial.fetch_data()` => `Metric._unwrap_trial_data_multi(results=trial.fetch_data())`.
In the future we may want to add some copy in the tutorials discussing Result, but we should land this for now to get things working again ASAP
Reviewed By: dme65
Differential Revision: D40994060
fbshipit-source-id: 9a5f86273a7da8496e480a0d7ca0aa2c03ecb1941 parent 48f2047 commit 7563a0b
1 file changed
+2
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1085 | 1085 | | |
1086 | 1086 | | |
1087 | 1087 | | |
| 1088 | + | |
1088 | 1089 | | |
1089 | 1090 | | |
1090 | 1091 | | |
| |||
1106 | 1107 | | |
1107 | 1108 | | |
1108 | 1109 | | |
1109 | | - | |
| 1110 | + | |
1110 | 1111 | | |
1111 | 1112 | | |
1112 | 1113 | | |
| |||
0 commit comments