Commit ecd0b19
Change defaults MC Samples to 512 (#1535)
Summary:
<!--
Thank you for sending the PR! We appreciate you spending the time to make BoTorch better.
Help us understand your motivation by explaining why you decided to make this change.
You can learn more about contributing to BoTorch here: https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md
-->
## Motivation
I just recognized that in `get_acquisition_function` a default of 500 mc samples is used, but when one initializes an MC acquisition function directly a default of 512 samples is used: https://github.com/pytorch/botorch/blob/8ecc903392b21ad9468c9b45f26b867d51378461/botorch/acquisition/acquisition.py#L149 I think it makes sense to keep things consistent. In addition, I think it is recommended for sobol sampling to use a sampling size which corresponds to basis 2.
### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)?
Yes.
Pull Request resolved: #1535
Test Plan: Only default value is changed. No tests necessary.
Reviewed By: Balandat
Differential Revision: D41651210
Pulled By: saitcakmak
fbshipit-source-id: 12c0652eef45ee1493db2939ac3bcbacd191e2131 parent 8ecc903 commit ecd0b19
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
0 commit comments