Skip to content

Commit 24b9a7f

Browse files
pablorfb-metafacebook-github-bot
authored andcommitted
Fix metric
Summary: Incorrectly capturing initial connection as reconnection. Created from CodeHub with https://fburl.com/edit-in-codehub Reviewed By: amirafzali Differential Revision: D79689362 fbshipit-source-id: 147d007c67eacf2f505da1247dfdcaf3383127c3
1 parent c222810 commit 24b9a7f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

hyperactor/src/channel/net.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -721,11 +721,11 @@ impl<M: RemoteMessage> NetTx<M> {
721721
.expect("unexpected serialization error");
722722
let initialized = sink.send(data.into()).await.is_ok();
723723

724-
metrics::CHANNEL_RECONNECTIONS.add(
724+
metrics::CHANNEL_CONNECTIONS.add(
725725
1,
726726
hyperactor_telemetry::kv_pairs!(
727727
"transport" => link.dest().transport().to_string(),
728-
"reason" => "network_flakiness",
728+
"reason" => "link connected",
729729
),
730730
);
731731

0 commit comments

Comments
 (0)