yet more lints (#790)

Summary:
Pull Request resolved: #790

lints

Reviewed By: pablorfb-meta

Differential Revision: D79808406

fbshipit-source-id: 0a2bc7edabb9c072bd53e32aa89598f7bd5c0e64

Author: shayne-fletcher

hyperactor/src/proc.rs

@@ -2615,7 +2615,7 @@ mod tests {
         impl Actor for TestActor {
             type Params = ();
 
-            async fn new(param: ()) -> Result<Self, anyhow::Error> {
+            async fn new(_param: ()) -> Result<Self, anyhow::Error> {
                 Ok(Self)
             }
         }

hyperactor_mesh/benches/main.rs

@@ -22,7 +22,6 @@ use hyperactor_mesh::alloc::LocalAllocator;
 use hyperactor_mesh::extent;
 use hyperactor_mesh::selection::dsl::all;
 use hyperactor_mesh::selection::dsl::true_;
-use hyperactor_mesh::shape;
 use tokio::time::Duration;
 
 mod bench_actor;

monarch_extension/Cargo.toml

@@ -33,7 +33,6 @@ monarch_types = { version = "0.0.0", path = "../monarch_types" }
 nccl-sys = { path = "../nccl-sys", optional = true }
 ndslice = { version = "0.0.0", path = "../ndslice" }
 pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods"] }
-pyo3-async-runtimes = { version = "0.24", features = ["attributes", "tokio-runtime"] }
 rdmaxcel-sys = { path = "../rdmaxcel-sys", optional = true }
 serde = { version = "1.0.219", features = ["derive", "rc"] }
 tokio = { version = "1.46.1", features = ["full", "test-util", "tracing"] }

monarch_hyperactor/src/actor_mesh.rs

@@ -10,8 +10,6 @@ use std::sync::Arc;
 
 use hyperactor::ActorRef;
 use hyperactor::id;
-use hyperactor::mailbox::OncePortReceiver;
-use hyperactor::mailbox::PortReceiver;
 use hyperactor::supervision::ActorSupervisionEvent;
 use hyperactor_mesh::Mesh;
 use hyperactor_mesh::RootActorMesh;
@@ -20,30 +18,23 @@ use hyperactor_mesh::actor_mesh::ActorSupervisionEvents;
 use hyperactor_mesh::reference::ActorMeshRef;
 use hyperactor_mesh::shared_cell::SharedCell;
 use hyperactor_mesh::shared_cell::SharedCellRef;
-use pyo3::IntoPyObjectExt;
-use pyo3::exceptions::PyEOFError;
 use pyo3::exceptions::PyException;
 use pyo3::exceptions::PyNotImplementedError;
 use pyo3::exceptions::PyRuntimeError;
-use pyo3::exceptions::PyTypeError;
 use pyo3::exceptions::PyValueError;
 use pyo3::prelude::*;
 use pyo3::types::PyBytes;
 use pyo3::types::PyDict;
 use pyo3::types::PySlice;
 use serde::Deserialize;
 use serde::Serialize;
-use tokio::sync::Mutex;
 
 use crate::actor::PythonActor;
 use crate::actor::PythonMessage;
 use crate::mailbox::PyMailbox;
-use crate::mailbox::PythonOncePortReceiver;
-use crate::mailbox::PythonPortReceiver;
 use crate::proc::PyActorId;
 use crate::proc_mesh::Keepalive;
 use crate::pytokio::PyPythonTask;
-use crate::pytokio::PythonTask;
 use crate::selection::PySelection;
 use crate::shape::PyShape;
 use crate::supervision::SupervisionError;

monarch_hyperactor/src/mailbox.rs

@@ -408,7 +408,8 @@ impl PythonPortReceiver {
 }
 
 impl PythonPortReceiver {
-    pub fn inner(&self) -> Arc<tokio::sync::Mutex<PortReceiver<PythonMessage>>> {
+    #[allow(dead_code)]
+    pub(super) fn inner(&self) -> Arc<tokio::sync::Mutex<PortReceiver<PythonMessage>>> {
         Arc::clone(&self.inner)
     }
 }
@@ -574,7 +575,8 @@ impl PythonOncePortReceiver {
 }
 
 impl PythonOncePortReceiver {
-    pub fn inner(&self) -> Arc<std::sync::Mutex<Option<OncePortReceiver<PythonMessage>>>> {
+    #[allow(dead_code)]
+    pub(super) fn inner(&self) -> Arc<std::sync::Mutex<Option<OncePortReceiver<PythonMessage>>>> {
         Arc::clone(&self.inner)
     }
 }

monarch_hyperactor/src/runtime.rs

@@ -88,7 +88,7 @@ pub fn initialize(py: Python) -> Result<()> {
         py,
         None,
         None,
-        |args: &Bound<'_, PyTuple>, _kwargs: Option<&Bound<'_, PyDict>>| {
+        |_args: &Bound<'_, PyTuple>, _kwargs: Option<&Bound<'_, PyDict>>| {
             shutdown_tokio_runtime();
         },
     )