Remove unused def undeliverable_receiver from PyMailbox (#1436)

Summary:
Pull Request resolved: #1436

Originally added in D77456497 2 months ago but it was never used. Remove it to reduce unnecessary maintenance burden. We can add it back when we need it again.

Reviewed By: mariusae

Differential Revision: D83912653

fbshipit-source-id: d48b2e7b468b423309d37d4fbd4aac05d9b44865

Author: pzhan9

monarch_hyperactor/src/mailbox.rs

@@ -52,7 +52,6 @@ use crate::instance_dispatch;
 use crate::proc::PyActorId;
 use crate::pytokio::PyPythonTask;
 use crate::pytokio::PythonTask;
-use crate::runtime::signal_safe_block_on;
 
 #[derive(Clone, Debug)]
 #[pyclass(
@@ -146,22 +145,6 @@ impl PyMailbox {
         }
     }
 
-    fn undeliverable_receiver<'py>(
-        &self,
-        py: Python<'py>,
-    ) -> PyResult<Py<PythonUndeliverablePortReceiver>> {
-        let (handle, receiver) = self.inner.open_port();
-        handle.bind_to(Undeliverable::<MessageEnvelope>::port());
-        let receiver = Py::new(
-            py,
-            PythonUndeliverablePortReceiver {
-                inner: Arc::new(tokio::sync::Mutex::new(receiver)),
-            },
-        )?;
-
-        Ok(receiver)
-    }
-
     fn __repr__(&self) -> String {
         format!("{:?}", self.inner)
     }
@@ -281,22 +264,6 @@ impl PythonPortHandle {
     }
 }
 
-#[derive(Clone, Debug)]
-#[pyclass(
-    name = "UndeliverablePortHandle",
-    module = "monarch._rust_bindings.monarch_hyperactor.mailbox"
-)]
-pub(super) struct PythonUndeliverablePortHandle {
-    inner: PortHandle<Undeliverable<MessageEnvelope>>,
-}
-
-#[pymethods]
-impl PythonUndeliverablePortHandle {
-    fn bind_undeliverable(&self) {
-        self.inner.bind_to(Undeliverable::<MessageEnvelope>::port());
-    }
-}
-
 #[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
 #[pyclass(
     name = "PortRef",
@@ -437,46 +404,6 @@ impl PythonUndeliverableMessageEnvelope {
     }
 }
 
-#[derive(Debug)]
-#[pyclass(
-    name = "UndeliverablePortReceiver",
-    module = "monarch._rust_bindings.monarch_hyperactor.mailbox"
-)]
-pub(super) struct PythonUndeliverablePortReceiver {
-    inner: Arc<tokio::sync::Mutex<PortReceiver<Undeliverable<MessageEnvelope>>>>,
-}
-
-#[pymethods]
-impl PythonUndeliverablePortReceiver {
-    fn recv<'py>(&mut self, py: Python<'py>) -> PyResult<Bound<'py, PyAny>> {
-        let receiver = self.inner.clone();
-        crate::runtime::future_into_py(py, async move {
-            let message = receiver
-                .lock()
-                .await
-                .recv()
-                .await
-                .map_err(|err| PyErr::new::<PyEOFError, _>(format!("Port closed: {}", err)))?;
-            Ok(PythonUndeliverableMessageEnvelope {
-                inner: Some(message),
-            })
-        })
-    }
-
-    fn blocking_recv<'py>(
-        &mut self,
-        py: Python<'py>,
-    ) -> PyResult<PythonUndeliverableMessageEnvelope> {
-        let receiver = self.inner.clone();
-        let message = signal_safe_block_on(py, async move { receiver.lock().await.recv().await })?
-            .map_err(|err| PyErr::new::<PyEOFError, _>(format!("Port closed: {}", err)))?;
-
-        Ok(PythonUndeliverableMessageEnvelope {
-            inner: Some(message),
-        })
-    }
-}
-
 #[derive(Debug)]
 #[pyclass(
     name = "OncePortHandle",
@@ -728,10 +655,8 @@ pub fn register_python_bindings(hyperactor_mod: &Bound<'_, PyModule>) -> PyResul
     hyperactor_mod.add_class::<PyMailbox>()?;
     hyperactor_mod.add_class::<PyPortId>()?;
     hyperactor_mod.add_class::<PythonPortHandle>()?;
-    hyperactor_mod.add_class::<PythonUndeliverablePortHandle>()?;
     hyperactor_mod.add_class::<PythonPortRef>()?;
     hyperactor_mod.add_class::<PythonPortReceiver>()?;
-    hyperactor_mod.add_class::<PythonUndeliverablePortReceiver>()?;
     hyperactor_mod.add_class::<PythonOncePortHandle>()?;
     hyperactor_mod.add_class::<PythonOncePortRef>()?;
     hyperactor_mod.add_class::<PythonOncePortReceiver>()?;

python/monarch/_rust_bindings/monarch_hyperactor/mailbox.pyi

@@ -160,15 +160,6 @@ class Mailbox:
         """
         ...
 
-    def undeliverable_receiver(self) -> UndeliverablePortReceiver:
-        """
-        Open a port to receive undeliverable messages.
-
-        This may only be called at most once per mailbox. Calling it
-        more than once may panic due to the port already being bound.
-        """
-        ...
-
     @property
     def actor_id(self) -> ActorId: ...