Skip to content

Commit 54b7a06

Browse files
pzhan9meta-codesync[bot]
authored andcommitted
Merge actor_mesh field to actor_name (#1940)
Summary: Pull Request resolved: #1940 `actor mesh name` is the same as the `actor name`. This diff removes the `actor_mesh` column, and only use `actor_name`. In this way, we can search scuba with 1 column and get all the logs related to an actor mesh. Reviewed By: dulinriley Differential Revision: D87459230 fbshipit-source-id: eb75ebcd88a164c7cbd8d009e3a3891da43110ea
1 parent fc3e30e commit 54b7a06

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

hyperactor_mesh/src/v1/actor_mesh.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ impl<A: Referable> Drop for ActorMesh<A> {
117117
fn drop(&mut self) {
118118
tracing::info!(
119119
name = "ActorMeshStatus",
120-
actor_mesh = %self.name,
120+
actor_name = %self.name,
121121
status = "Dropped",
122122
);
123123
}

hyperactor_mesh/src/v1/proc_mesh.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -882,7 +882,7 @@ impl ProcMeshRef {
882882
#[hyperactor::instrument(fields(
883883
host_mesh=self.host_mesh_name().map(|n| n.to_string()),
884884
proc_mesh=self.name.to_string(),
885-
actor_mesh=name.to_string(),
885+
actor_name=name.to_string(),
886886
))]
887887
pub(crate) async fn spawn_with_name<A: Actor + Referable>(
888888
&self,

monarch_hyperactor/src/v1/actor_mesh.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ fn send_state_change<F>(
500500
#[hyperactor::instrument_infallible(fields(
501501
host_mesh=actor_mesh.proc_mesh().host_mesh_name().map(|n| n.to_string()),
502502
proc_mesh=actor_mesh.proc_mesh().name().to_string(),
503-
actor_mesh=actor_mesh.name().to_string(),
503+
actor_name=actor_mesh.name().to_string(),
504504
))]
505505
async fn actor_states_monitor<A, F>(
506506
cx: &impl context::Actor,

0 commit comments

Comments
 (0)