Skip to content

Commit 5c0302d

Browse files
moonlifacebook-github-bot
authored andcommitted
abort log tailer for proc during proc shutdown (#811)
Summary: Pull Request resolved: #811 When proc stops, we shutdown all actors and exit the process. We also join the log tailers. We need to explicitly abort the log tailers to make sure joining won't be stuck. Reviewed By: vidhyav Differential Revision: D79932041 fbshipit-source-id: 9a19fdcfd9db1f2c2e883288c016a4869fffc3fd
1 parent 6f01e6a commit 5c0302d

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

hyperactor_mesh/src/alloc/process.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -473,6 +473,8 @@ impl Alloc for ProcessAlloc {
473473

474474
Some(Ok((index, mut reason))) = self.children.join_next() => {
475475
let stderr_content = if let Some(Child { stdout, stderr, ..} ) = self.remove(index) {
476+
stdout.abort();
477+
stderr.abort();
476478
let (_stdout, _) = stdout.join().await;
477479
let (stderr_lines, _) = stderr.join().await;
478480
stderr_lines.join("\n")

0 commit comments

Comments
 (0)