Skip to content

Commit 958dc28

Browse files
: python/tests/test_actors.py: no fork re-enable some tests (#1949)
Summary: Pull Request resolved: #1949 Differential Revision: D87507353
1 parent 257e356 commit 958dc28

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

python/tests/test_python_actors.py

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -554,8 +554,7 @@ def redirected_stdio(capture_stderr: bool = True) -> Iterator[RedirectedPaths]:
554554
pass
555555

556556

557-
# oss_skip: pytest keeps complaining about mocking get_ipython module
558-
@pytest.mark.oss_skip
557+
@pytest.mark.timeout(180)
559558
async def test_actor_log_streaming() -> None:
560559
with configured(
561560
enable_log_forwarding=True, enable_file_capture=True, tail_log_lines=100
@@ -662,9 +661,7 @@ async def test_actor_log_streaming() -> None:
662661
), stderr_content
663662

664663

665-
# oss_skip: pytest keeps complaining about mocking get_ipython module
666-
# oss_skip: (SF) broken in GitHub by D86994420. Passes internally.
667-
@pytest.mark.oss_skip
664+
@pytest.mark.timeout(180)
668665
async def test_alloc_based_log_streaming() -> None:
669666
"""Test both AllocHandle.stream_logs = False and True cases."""
670667

@@ -735,8 +732,7 @@ def _stream_logs(self) -> bool:
735732
await test_stream_logs_case(True, "stream_logs_true")
736733

737734

738-
# oss_skip: (SF) broken in GitHub by D86994420. Passes internally.
739-
@pytest.mark.oss_skip
735+
@pytest.mark.timeout(180)
740736
async def test_logging_option_defaults() -> None:
741737
with configured(
742738
enable_log_forwarding=True, enable_file_capture=True, tail_log_lines=100
@@ -802,8 +798,7 @@ def __init__(self):
802798
self.events = MockEvents()
803799

804800

805-
# oss_skip: pytest keeps complaining about mocking get_ipython module
806-
@pytest.mark.oss_skip
801+
@pytest.mark.timeout(180)
807802
async def test_flush_called_only_once() -> None:
808803
"""Test that flush is called only once when ending an ipython cell"""
809804
with configured(
@@ -833,8 +828,6 @@ async def test_flush_called_only_once() -> None:
833828
assert mock_flush.call_count == 1
834829

835830

836-
# oss_skip: pytest keeps complaining about mocking get_ipython module
837-
@pytest.mark.oss_skip
838831
@pytest.mark.timeout(180)
839832
async def test_flush_logs_ipython() -> None:
840833
"""Test that logs are flushed when get_ipython is available and post_run_cell event is triggered."""
@@ -895,7 +888,8 @@ async def test_flush_logs_ipython() -> None:
895888
assert len(re.findall(pattern2, stdout_content)) >= 3, stdout_content
896889

897890

898-
# oss_skip: importlib not pulling resource correctly in git CI, needs to be revisited
891+
# oss_skip: importlib not pulling resource correctly in git CI, needs
892+
# to be revisited
899893
@pytest.mark.oss_skip
900894
async def test_flush_logs_fast_exit() -> None:
901895
with configured(
@@ -928,8 +922,7 @@ async def test_flush_logs_fast_exit() -> None:
928922
), process.stdout
929923

930924

931-
# oss_skip: (SF) broken in GitHub by D86994420. Passes internally.
932-
@pytest.mark.oss_skip
925+
@pytest.mark.timeout(180)
933926
async def test_flush_on_disable_aggregation() -> None:
934927
"""Test that logs are flushed when disabling aggregation.
935928
@@ -1026,8 +1019,7 @@ async def test_multiple_ongoing_flushes_no_deadlock() -> None:
10261019
futures[-1].get()
10271020

10281021

1029-
# oss_skip: (SF) broken in GitHub by D86994420. Passes internally.
1030-
@pytest.mark.oss_skip
1022+
@pytest.mark.timeout(180)
10311023
async def test_adjust_aggregation_window() -> None:
10321024
"""Test that the flush deadline is updated when the aggregation window is adjusted.
10331025

0 commit comments

Comments
 (0)