Skip to content

Commit c175f21

Browse files
pablorfb-metameta-codesync[bot]
authored andcommitted
Fix Service lab runs (#1413)
Summary: Pull Request resolved: #1413 D81327127 changed the names of the runs without registering them on target, causing svc lab to breake [e.g.](https://www.internalfb.com/servicelab/experiments?q=%7B%22key%22%3A%22AND%22%2C%22children%22%3A[%7B%22key%22%3A%22SL_EXPERIMENTS_WORKLOAD_CONTAINS_TEXT%22%2C%22field%22%3A%22SL_EXPERIMENTS_WORKLOAD%22%2C%22value%22%3A%22benchmark_py_actor_mesh_benchmark%22%7D]%7D) we add registration here. Reviewed By: colin2328 Differential Revision: D83770161 fbshipit-source-id: 609676ef42091a7dfad72a8c6dbff1336ba468c5
1 parent 16e3de3 commit c175f21

File tree

1 file changed

+3
-23
lines changed

1 file changed

+3
-23
lines changed

python/benches/actor_mesh_benchmark.py

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -209,13 +209,7 @@ async def teardown(self) -> None:
209209
assert self.pong_mesh is not None
210210
await self.pong_mesh.stop()
211211

212-
def setup_env(self) -> None:
213-
# ensure any changes are reflected
214-
os.environ["HYPERACTOR_DEFAULT_ENCODING"] = "serde_bincode"
215-
os.environ["HYPERACTOR_CHANNEL_MULTIPART"] = "0"
216-
217212
async def setup(self) -> None:
218-
self.setup_env()
219213
reload_config_from_env()
220214
pong_mesh = proc_mesh(hosts=self.host_count, gpus=self.gpu_count)
221215
await pong_mesh.logging_option(stream_to_client=True, aggregate_window_sec=None)
@@ -225,12 +219,6 @@ async def setup(self) -> None:
225219
self.message = bytes(self.message_size)
226220

227221

228-
class ActorLatencyMultipart(ActorLatency):
229-
def setup_env(self) -> None:
230-
os.environ["HYPERACTOR_DEFAULT_ENCODING"] = "serde_multipart"
231-
os.environ["HYPERACTOR_CHANNEL_MULTIPART"] = "1"
232-
233-
234222
@dataclass
235223
class ActorThroughput(ActorLatency):
236224
request_batch_size: int = 10
@@ -253,22 +241,14 @@ async def run_once(self) -> None:
253241
self.bump_counter("messages", pong.size() * self.request_batch_size)
254242

255243

256-
class ActorThroughputMultipart(ActorThroughput):
257-
def setup_env(self) -> None:
258-
os.environ["HYPERACTOR_DEFAULT_ENCODING"] = "serde_multipart"
259-
os.environ["HYPERACTOR_CHANNEL_MULTIPART"] = "1"
260-
261-
262-
message_sizes: list[int] = [10**n for n in range(1, 9)]
263-
host_counts = [1, 8, 16]
264-
gpu_counts = [1, 8]
244+
message_sizes: list[int] = [10**n for n in range(3, 9, 2)]
245+
host_counts = [1, 10]
246+
gpu_counts = [1, 10]
265247
host_counts = [1]
266248
gpu_counts = [1]
267249
runners = [
268250
ActorLatency,
269-
ActorLatencyMultipart,
270251
ActorThroughput,
271-
ActorThroughputMultipart,
272252
]
273253

274254
for hosts, gpus, message_size, Runner in itertools.product(

0 commit comments

Comments
 (0)