Skip to content

Commit d417d18

Browse files
mariusaemeta-codesync[bot]
authored andcommitted
move timing headers to send_serialized (#1379)
Summary: Pull Request resolved: #1379 ... because this is at the bottom of the send stack. Also move headers before message to be consistent. ghstack-source-id: 313885566 exported-using-ghexport Reviewed By: jayasi, shayne-fletcher Differential Revision: D83570413 fbshipit-source-id: 329e266cf176a823e41cf37c8cf3bc69474dd486
1 parent 53a2a2d commit d417d18

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

hyperactor/src/reference.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,7 +1022,7 @@ impl<M: RemoteMessage> PortRef<M> {
10221022
MailboxSenderErrorKind::Serialize(err.into()),
10231023
)
10241024
})?;
1025-
self.send_serialized(cx, serialized, headers);
1025+
self.send_serialized(cx, headers, serialized);
10261026
Ok(())
10271027
}
10281028

@@ -1031,8 +1031,8 @@ impl<M: RemoteMessage> PortRef<M> {
10311031
pub fn send_serialized(
10321032
&self,
10331033
cx: &impl context::Mailbox,
1034-
message: Serialized,
10351034
mut headers: Attrs,
1035+
message: Serialized,
10361036
) {
10371037
crate::mailbox::headers::set_send_timestamp(&mut headers);
10381038
cx.post(self.port_id.clone(), headers, message);

monarch_simulator/src/controller.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ impl ControllerMessageHandler for SimControllerActor {
113113
tracing::info!("controller send to ranks {:?}: {}", ranks, message);
114114
self.worker_actor_ref
115115
.port::<WorkerMessage>()
116-
.send_serialized(cx, message, Attrs::new());
116+
.send_serialized(cx, Attrs::new(), message);
117117
Ok(())
118118
}
119119

0 commit comments

Comments
 (0)