port v0 multi-process test to v1 #1976
Closed
+115
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87680283. |
Summary: port undeliverable-message coverage from hyperactor_multiprocess into v1 mesh in preparation for retiring hyperactor_multiprocess. this moves the undeliverable-message test from `hyperactor_multiprocess::proc_actor` into the v1 mesh layer and deletes the old version. the new test uses `testing::proc_meshes` with two replicas, runs `PingPongActor` on each, confirms ping→pong works, then shuts down the pong replica and sends a batch of messages. all undeliverables are routed back via the bound port, demonstrating that the sender stays alive and correctly handles delivery failures in the mesh-based setup. Reviewed By: mariusae Differential Revision: D87680283
shayne-fletcher
force-pushed
the
export-D87680283
branch
from
4e00604 to
6d5a1a8
Compare
|
This pull request has been merged in 4d4b610. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
port undeliverable-message coverage from hyperactor_multiprocess into v1 mesh in preparation for retiring hyperactor_multiprocess.
this moves the undeliverable-message test from
hyperactor_multiprocess::proc_actorinto the v1 mesh layer and deletes the old version. the new test usestesting::proc_mesheswith two replicas, runsPingPongActoron each, confirms ping→pong works, then shuts down the pong replica and sends a batch of messages. all undeliverables are routed back via the bound port, demonstrating that the sender stays alive and correctly handles delivery failures in the mesh-based setup.Differential Revision: D87680283