Skip to content

Commit 079de41

Browse files
committed
Add comment
1 parent 2c9eb1f commit 079de41

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

test/test_encoders.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,13 @@ def validate_frames_properties(*, actual: Path, expected: Path):
6969
assert all(required_prop in d_actual for required_prop in required_props)
7070
for prop in d_expected:
7171
if prop == "pkt_pos":
72-
continue # TODO this probably matters
72+
# pkt_pos is the position of the packet *in bytes* in its
73+
# stream. We don't always match FFmpeg exactly on this,
74+
# typically on compressed formats like mp3. It's probably
75+
# because we are not writing the exact same headers, or
76+
# something like this. In any case, this doesn't seem to be
77+
# critical.
78+
continue
7379
assert (
7480
d_actual[prop] == d_expected[prop]
7581
), f"\nComparing: {actual}\nagainst reference: {expected},\nthe {prop} property is different at frame {frame_index}:"

0 commit comments

Comments
 (0)