Skip to content

Commit 1beb055

Browse files
committed
Add comment
1 parent 490c13b commit 1beb055

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

src/torchcodec/_core/BetaCudaDeviceInterface.cpp

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,18 @@ cudaVideoCodec validateCodecSupport(AVCodecID codecId) {
156156
return cudaVideoCodec_VP8;
157157
case AV_CODEC_ID_MPEG4:
158158
return cudaVideoCodec_MPEG4;
159-
// TODONVDEC P0: support more codecs
160-
// case AV_CODEC_ID_MJPEG: return cudaVideoCodec_JPEG;
159+
// Formats below are currently not tested, but they should "mostly" work.
160+
// MPEG1 was briefly locally tested and it was ok-ish despite duration being
161+
// off. Since they're far less popular, we keep them disabled by default but
162+
// we can consider enabling them upon user requests.
163+
// case AV_CODEC_ID_MPEG1VIDEO:
164+
// return cudaVideoCodec_MPEG1;
165+
// case AV_CODEC_ID_MPEG2VIDEO:
166+
// return cudaVideoCodec_MPEG2;
167+
// case AV_CODEC_ID_MJPEG:
168+
// return cudaVideoCodec_JPEG;
169+
// case AV_CODEC_ID_VC1:
170+
// return cudaVideoCodec_VC1;
161171
default: {
162172
TORCH_CHECK(false, "Unsupported codec type: ", avcodec_get_name(codecId));
163173
}

0 commit comments

Comments
 (0)