@@ -47,23 +47,23 @@ First let's consider implementing the "easy" case of Resize.
4747 ` VideoDecoder ` . It is a sequence of TorchVision Transforms.
48482 . During VideoDecoder object creation, we walk the list, capturing two
4949 pieces of information:
50- a . The transform name that the C++ layer will understand. (We will
51- have to decide if we want to just use the FFmpeg filter name
52- here, the fully resolved Transform name, or introduce a new
53- naming layer.)
54- b . The parameters in a format that the C++ layer will understand. We
55- obtain them by calling ` make_params() ` on the Transform object.
50+ 1 . The transform name that the C++ layer will understand. (We will
51+ have to decide if we want to just use the FFmpeg filter name
52+ here, the fully resolved Transform name, or introduce a new
53+ naming layer.)
54+ 2 . The parameters in a format that the C++ layer will understand. We
55+ obtain them by calling ` make_params() ` on the Transform object.
56563 . We add an optional transforms parameter to ` core.add_video_stream() ` . This
5757 parameter will be a vector, but whether the vector contains strings,
5858 tensors, or some combination of them is TBD.
59594 . The ` custom_ops.cpp ` and ` pybind_ops.cpp ` layer is responsible for turning
6060 the values passed from the Python layer into transform objects that the
6161 C++ layer knows about. We will have one class per transform we support.
6262 Each class will have:
63- a . A name which matches the FFmpeg filter name.
64- b . One member for each supported parameter.
65- c . A virtual member function that knows how to produce a string that
66- can be passed to FFmpeg's filtergraph.
63+ 1 . A name which matches the FFmpeg filter name.
64+ 2 . One member for each supported parameter.
65+ 3 . A virtual member function that knows how to produce a string that
66+ can be passed to FFmpeg's filtergraph.
67675 . We add a vector of such transforms to
6868 ` SingleStreamDecoder::addVideoStream ` . We store the vector as a field in
6969 ` SingleStreamDecoder ` .
0 commit comments