Remove getNextAVFrameNoDemux() (#470)

Co-authored-by: Scott Schneider <[email protected]>

Author: NicolasHug

src/torchcodec/decoders/_core/VideoDecoder.cpp

@@ -1472,15 +1472,6 @@ VideoDecoder::FrameBatchOutput VideoDecoder::getFramesPlayedInRange(
   return frameBatchOutput;
 }
 
-VideoDecoder::AVFrameStream VideoDecoder::getNextAVFrameNoDemux() {
-  auto avFrameStream = getAVFrameUsingFilterFunction(
-      [this](int frameStreamIndex, AVFrame* avFrame) {
-        StreamInfo& activeStreamInfo = streamInfos_[frameStreamIndex];
-        return avFrame->pts >= activeStreamInfo.discardFramesBeforePts;
-      });
-  return avFrameStream;
-}
-
 VideoDecoder::FrameOutput VideoDecoder::getNextFrameNoDemux() {
   auto output = getNextFrameNoDemuxInternal();
   output.data = maybePermuteHWC2CHW(output.streamIndex, output.data);
@@ -1489,7 +1480,11 @@ VideoDecoder::FrameOutput VideoDecoder::getNextFrameNoDemux() {
 
 VideoDecoder::FrameOutput VideoDecoder::getNextFrameNoDemuxInternal(
     std::optional<torch::Tensor> preAllocatedOutputTensor) {
-  auto avFrameStream = getNextAVFrameNoDemux();
+  AVFrameStream avFrameStream = getAVFrameUsingFilterFunction(
+      [this](int frameStreamIndex, AVFrame* avFrame) {
+        StreamInfo& activeStreamInfo = streamInfos_[frameStreamIndex];
+        return avFrame->pts >= activeStreamInfo.discardFramesBeforePts;
+      });
   return convertAVFrameToFrameOutput(avFrameStream, preAllocatedOutputTensor);
 }
 

src/torchcodec/decoders/_core/VideoDecoder.h

@@ -403,7 +403,6 @@ class VideoDecoder {
   void maybeSeekToBeforeDesiredPts();
   AVFrameStream getAVFrameUsingFilterFunction(
       std::function<bool(int, AVFrame*)>);
-  AVFrameStream getNextAVFrameNoDemux();
   // Once we create a decoder can update the metadata with the codec context.
   // For example, for video streams, we can add the height and width of the
   // decoded stream.