Skip to content

Commit 3890227

Browse files
committed
don't return encoded bytes for now
1 parent a1532c9 commit 3890227

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/torchcodec/decoders/_core/VideoDecoder.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2145,7 +2145,7 @@ Encoder::Encoder(int sampleRate, std::string_view fileName)
21452145
avcodec_parameters_from_context(avStream_->codecpar, avCodecContext_.get());
21462146
}
21472147

2148-
torch::Tensor Encoder::encode(const torch::Tensor& wf) {
2148+
void Encoder::encode(const torch::Tensor& wf) {
21492149
UniqueAVFrame avFrame(av_frame_alloc());
21502150
TORCH_CHECK(avFrame != nullptr, "Couldn't allocate AVFrame.");
21512151
avFrame->nb_samples = avCodecContext_->frame_size;
@@ -2222,9 +2222,6 @@ torch::Tensor Encoder::encode(const torch::Tensor& wf) {
22222222
ffmpegRet == AVSUCCESS,
22232223
"Error in: av_write_trailer",
22242224
getFFMPEGErrorStringFromErrorCode(ffmpegRet));
2225-
2226-
// TODO handle writing to output uint8 tensor with AVIO logic.
2227-
return torch::empty({10});
22282225
}
22292226

22302227
void Encoder::encode_inner_loop(AutoAVPacket& autoAVPacket, AVFrame* avFrame) {

src/torchcodec/decoders/_core/VideoDecoder.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ class Encoder {
597597
// TODO doesn't make much sense to pass fileName and the wf tensor in 2
598598
// different calls. Same with sampleRate.
599599
Encoder(int sampleRate, std::string_view fileName);
600-
torch::Tensor encode(const torch::Tensor& wf);
600+
void encode(const torch::Tensor& wf);
601601

602602
private:
603603
void encode_inner_loop(AutoAVPacket& autoAVPacket, AVFrame* avFrame);

src/torchcodec/decoders/_core/VideoDecoderOps.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ TORCH_LIBRARY(torchcodec_ns, m) {
2929
"torchcodec.decoders._core.ops", "//pytorch/torchcodec:torchcodec");
3030
m.def("create_from_file(str filename, str? seek_mode=None) -> Tensor");
3131
m.def("create_encoder(int sample_rate, str filename) -> Tensor");
32-
m.def("encode(Tensor(a!) encoder, Tensor wf) -> Tensor");
32+
m.def("encode(Tensor(a!) encoder, Tensor wf) -> ()");
3333
m.def(
3434
"create_from_tensor(Tensor video_tensor, str? seek_mode=None) -> Tensor");
3535
m.def("_convert_to_tensor(int decoder_ptr) -> Tensor");
@@ -151,9 +151,9 @@ at::Tensor create_encoder(int64_t sample_rate, std::string_view file_name) {
151151
return wrapEncoderPointerToTensor(std::move(uniqueEncoder));
152152
}
153153

154-
at::Tensor encode(at::Tensor& encoder, const at::Tensor& wf) {
154+
void encode(at::Tensor& encoder, const at::Tensor& wf) {
155155
auto encoder_ = unwrapTensorToGetEncoder(encoder);
156-
return encoder_->encode(wf);
156+
encoder_->encode(wf);
157157
}
158158

159159
at::Tensor create_from_tensor(

0 commit comments

Comments
 (0)