address feedback

Author: Molly Xu

src/torchcodec/_core/BetaCudaDeviceInterface.cpp

@@ -232,9 +232,8 @@ BetaCudaDeviceInterface::~BetaCudaDeviceInterface() {
 void BetaCudaDeviceInterface::initialize(
     const AVStream* avStream,
     const UniqueDecodingAVFormatContext& avFormatCtx,
-    const SharedAVCodecContext& codecContext) {
+    [[maybe_unused]] const SharedAVCodecContext& codecContext) {
   TORCH_CHECK(avStream != nullptr, "AVStream cannot be null");
-  codecContext_ = codecContext;
   timeBase_ = avStream->time_base;
   frameRateAvgFromFFmpeg_ = avStream->r_frame_rate;
 

src/torchcodec/_core/DeviceInterface.h

@@ -95,10 +95,9 @@ class DeviceInterface {
   // Returns AVSUCCESS on success, or other AVERROR on failure
   // Default implementation uses FFmpeg directly
   virtual int sendEOFPacket() {
-    if (!codecContext_) {
-      TORCH_CHECK(false, "Codec context not available for EOF packet sending");
-      return AVERROR(EINVAL);
-    }
+    TORCH_CHECK(
+        codecContext_ != nullptr,
+        "Codec context not available for default EOF packet sending");
     return avcodec_send_packet(codecContext_.get(), nullptr);
   }
 

src/torchcodec/_core/FFMPEGCommon.cpp

@@ -149,15 +149,6 @@ int getNumChannels(const UniqueAVFrame& avFrame) {
 #endif
 }
 
-int getNumChannels(const UniqueAVCodecContext& avCodecContext) {
-#if LIBAVFILTER_VERSION_MAJOR > 8 || \
-    (LIBAVFILTER_VERSION_MAJOR == 8 && LIBAVFILTER_VERSION_MINOR >= 44)
-  return avCodecContext->ch_layout.nb_channels;
-#else
-  return avCodecContext->channels;
-#endif
-}
-
 int getNumChannels(const SharedAVCodecContext& avCodecContext) {
 #if LIBAVFILTER_VERSION_MAJOR > 8 || \
     (LIBAVFILTER_VERSION_MAJOR == 8 && LIBAVFILTER_VERSION_MINOR >= 44)

src/torchcodec/_core/FFMPEGCommon.h

@@ -173,7 +173,6 @@ const AVSampleFormat* getSupportedOutputSampleFormats(const AVCodec& avCodec);
 const AVPixelFormat* getSupportedPixelFormats(const AVCodec& avCodec);
 
 int getNumChannels(const UniqueAVFrame& avFrame);
-int getNumChannels(const UniqueAVCodecContext& avCodecContext);
 int getNumChannels(const SharedAVCodecContext& avCodecContext);
 
 void setDefaultChannelLayout(