Fix stuff

Author: NicolasHug

src/torchcodec/decoders/__init__.py

@@ -7,6 +7,4 @@
 from ._core import VideoStreamMetadata
 from ._video_decoder import VideoDecoder  # noqa
 
-# from ._audio_decoder import AudioDecoder  # Will be public when more stable
-
 SimpleVideoDecoder = VideoDecoder

src/torchcodec/decoders/_core/FFMPEGCommon.cpp

@@ -70,8 +70,6 @@ int getNumChannels(const AVFrame* avFrame) {
 }
 
 int getNumChannels(const UniqueAVCodecContext& avCodecContext) {
-// Not sure about the exactness of the version bounds, but as long as this
-// compile we're fine.
 #if LIBAVFILTER_VERSION_MAJOR > 8 || \
     (IBAVFILTER_VERSION_MAJOR == 8 && LIBAVFILTER_VERSION_MINOR >= 44)
   return avCodecContext->ch_layout.nb_channels;

src/torchcodec/decoders/_core/_metadata.py

@@ -19,7 +19,9 @@
 )
 
 
-# TODO-audio: docs below are mostly for video streams.
+# TODO-audio: docs below are mostly for video streams, we should edit them and /
+# or make sure they're OK for audio streams as well. Not sure how to best handle
+# docs for such class hierarchy.
 @dataclass
 class StreamMetadata:
     duration_seconds_from_header: Optional[float]
@@ -154,6 +156,8 @@ def __repr__(self):
 
 @dataclass
 class AudioStreamMetadata(StreamMetadata):
+    """Metadata of a single audio stream."""
+
     # TODO-AUDIO do we expose the notion of frame here, like in fps? It's technically
     # valid, but potentially is an FFmpeg-specific concept for audio
     # TODO-AUDIO Need sample rate and format and num_channels

test/decoders/test_video_decoder_ops.py

@@ -400,7 +400,7 @@ def test_audio_get_json_metadata(self):
         decoder = create_from_file(str(NASA_AUDIO.path))
         metadata = get_json_metadata(decoder)
         metadata_dict = json.loads(metadata)
-        assert metadata_dict["durationSeconds"] == pytest.approx(13.013, abs=0.01)
+        assert metadata_dict["durationSeconds"] == pytest.approx(13.248, abs=0.01)
 
     def test_get_ffmpeg_version(self):
         ffmpeg_dict = get_ffmpeg_library_versions()