Skip to content

Commit 640a82d

Browse files
committed
Put back everything except ffmpeg4
1 parent 96592a7 commit 640a82d

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

.github/workflows/cpp_tests.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ jobs:
2121
matrix:
2222
# TODO put back 6.1.1. See
2323
# https://github.com/pytorch/torchcodec/issues/518
24-
ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '7.0.1']
24+
# TODO
25+
# ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '7.0.1']
26+
ffmpeg-version-for-tests: ['5.1.2', '7.0.1']
2527
steps:
2628
- name: Check out repo
2729
uses: actions/checkout@v3

.github/workflows/linux_cuda_wheel.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ jobs:
6868
python-version: ['3.9']
6969
cuda-version: ['11.8', '12.6', '12.8']
7070
# TODO: put back ffmpeg 5 https://github.com/pytorch/torchcodec/issues/325
71-
# ffmpeg-version-for-tests: ['4.4.2', '6', '7']
72-
ffmpeg-version-for-tests: ['7'] # TODO
71+
# TODO
72+
ffmpeg-version-for-tests: ['6', '7']
7373

7474
container:
7575
image: "pytorch/manylinux2_28-builder:cuda${{ matrix.cuda-version }}"

.github/workflows/linux_wheel.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,9 @@ jobs:
6262
fail-fast: false
6363
matrix:
6464
python-version: ['3.9']
65+
# TODO
6566
# ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '6.1.1', '7.0.1']
66-
ffmpeg-version-for-tests: ['7.0.1'] # TODO
67+
ffmpeg-version-for-tests: ['5.1.2', '6.1.1', '7.0.1']
6768
needs: build
6869
steps:
6970
- uses: actions/download-artifact@v4

.github/workflows/macos_wheel.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,9 @@ jobs:
6363
fail-fast: false
6464
matrix:
6565
python-version: ['3.9']
66+
# TODO
6667
# ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '6.1.1', '7.0.1']
67-
ffmpeg-version-for-tests: ['7.0.1'] # TODO
68+
ffmpeg-version-for-tests: ['5.1.2', '6.1.1', '7.0.1']
6869
needs: build
6970
steps:
7071
- name: Download wheel

src/torchcodec/decoders/_core/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ if(DEFINED ENV{BUILD_AGAINST_ALL_FFMPEG_FROM_S3})
8181
# TODO
8282
# make_torchcodec_library(libtorchcodec4 ffmpeg4)
8383
make_torchcodec_library(libtorchcodec7 ffmpeg7)
84-
# make_torchcodec_library(libtorchcodec6 ffmpeg6)
85-
# make_torchcodec_library(libtorchcodec5 ffmpeg5)
84+
make_torchcodec_library(libtorchcodec6 ffmpeg6)
85+
make_torchcodec_library(libtorchcodec5 ffmpeg5)
8686

8787
else()
8888
message(

0 commit comments

Comments
 (0)