Address some TODOs

Author: NicolasHug

src/torchcodec/_core/BetaCudaDeviceInterface.cpp

@@ -221,7 +221,6 @@ BetaCudaDeviceInterface::~BetaCudaDeviceInterface() {
   }
 
   if (videoParser_) {
-    // TODONVDEC P2: consider caching this? Does DALI do that?
     cuvidDestroyVideoParser(videoParser_);
     videoParser_ = nullptr;
   }

src/torchcodec/_core/NVDECCache.h

@@ -68,11 +68,8 @@ class NVDECCache {
     CacheKey(const CacheKey&) = default;
     CacheKey& operator=(const CacheKey&) = default;
 
-    // TODONVDEC P2: we only implement operator< which is enough for std::map,
-    // but:
-    // - we should consider using std::unordered_map
-    // - we should consider a more sophisticated and potentially less strict
-    // cache key comparison logic
+    // TODONVDEC P2: consider a more sophisticated and potentially
+    // less strict cache key comparison logic
     bool operator<(const CacheKey& other) const {
       return std::tie(
                  codecType,

src/torchcodec/decoders/_video_decoder.py

@@ -145,9 +145,6 @@ def __init__(
 
         # If device looks like "cuda:0:beta", make it "cuda:0" and set
         # device_variant to "beta"
-        # TODONVDEC P2 Consider alternative ways of exposing custom device
-        # variants, and if we want this new decoder backend to be a "device
-        # variant" at all.
         device_variant = "default"
         if device is not None:
             device_split = device.split(":")

test/utils.py

@@ -750,7 +750,7 @@ def sample_format(self) -> str:
 
 
 def supports_approximate_mode(asset: TestVideo) -> bool:
-    # TODONVDEC P2: open an issue about his. That's actually not related to
-    # NVDEC at all, those don't support approximate mode because they don't set
-    # a duration. CPU decoder fails too!
+    # Those are missing the `duration` field so they fail in approximate mode (on all devices).
+    # TODO: we should address this, see
+    # https://github.com/meta-pytorch/torchcodec/issues/945
     return asset not in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)