getNumFrames() should return optional in approximate mode

scotts · scotts · commit 7a6e6ca5d6e4 · 2025-06-02T07:05:09.000-07:00
diff --git a/src/torchcodec/_core/SingleStreamDecoder.cpp b/src/torchcodec/_core/SingleStreamDecoder.cpp
@@ -1487,7 +1487,7 @@ std::optional<int64_t> SingleStreamDecoder::getNumFrames(
     case SeekMode::exact:
       return streamMetadata.numFramesFromScan.value();
     case SeekMode::approximate: {
-      return streamMetadata.numFrames.value();
+      return streamMetadata.numFrames;
     }
     default:
       throw std::runtime_error("Unknown SeekMode");

Original file line number	Diff line number	Diff line change
`@@ -1487,7 +1487,7 @@ std::optional<int64_t> SingleStreamDecoder::getNumFrames(`
`1487`	`1487`	`case SeekMode::exact:`
`1488`	`1488`	`return streamMetadata.numFramesFromScan.value();`
`1489`	`1489`	`case SeekMode::approximate: {`
`1490`		`- return streamMetadata.numFrames.value();`
	`1490`	`+ return streamMetadata.numFrames;`
`1491`	`1491`	`}`
`1492`	`1492`	`default:`
`1493`	`1493`	`throw std::runtime_error("Unknown SeekMode");`