Skip to content

Commit 7d1d7fa

Browse files
authored
Drop 12.4 support (#521)
1 parent 1670372 commit 7d1d7fa

File tree

3 files changed

+9
-20
lines changed

3 files changed

+9
-20
lines changed

.github/workflows/docs.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ jobs:
7575
uses: pytorch/test-infra/.github/actions/setup-miniconda@main
7676
with:
7777
python-version: ${{ matrix.python-version }}
78-
#
79-
# For some reason nvidia::libnpp=12.4 doesn't install but nvidia/label/cuda-12.4.0::libnpp does.
80-
# So we use the latter convention for libnpp.
8178
# We install conda packages at the start because otherwise conda may have conflicts with dependencies.
8279
default-packages: "nvidia/label/cuda-${{ matrix.cuda-version }}.0::libnpp nvidia::cuda-nvrtc=${{ matrix.cuda-version }} nvidia::cuda-toolkit=${{ matrix.cuda-version }} nvidia::cuda-cudart=${{ matrix.cuda-version }} nvidia::cuda-driver-dev=${{ matrix.cuda-version }} conda-forge::ffmpeg=${{ matrix.ffmpeg-version-for-tests }}"
8380
- name: Check env

.github/workflows/linux_cuda_wheel.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,9 @@ jobs:
6666
# For the actual release we should add that label and change this to
6767
# include more python versions.
6868
python-version: ['3.9']
69-
cuda-version: ['11.8', '12.4', '12.6']
69+
cuda-version: ['11.8', '12.6']
7070
# TODO: put back ffmpeg 5 https://github.com/pytorch/torchcodec/issues/325
7171
ffmpeg-version-for-tests: ['4.4.2', '6', '7']
72-
exclude:
73-
- cuda-version: '12.4' # TODO put this back it fails with infra issue.
74-
ffmpeg-version-for-tests: '4.4.2'
7572

7673
container:
7774
image: "pytorch/manylinux2_28-builder:cuda${{ matrix.cuda-version }}"
@@ -92,9 +89,6 @@ jobs:
9289
uses: pytorch/test-infra/.github/actions/setup-miniconda@main
9390
with:
9491
python-version: ${{ matrix.python-version }}
95-
#
96-
# For some reason nvidia::libnpp=12.4 doesn't install but nvidia/label/cuda-12.4.0::libnpp does.
97-
# So we use the latter convention for libnpp.
9892
# We install conda packages at the start because otherwise conda may have conflicts with dependencies.
9993
default-packages: "nvidia/label/cuda-${{ matrix.cuda-version }}.0::libnpp nvidia::cuda-nvrtc=${{ matrix.cuda-version }} nvidia::cuda-toolkit=${{ matrix.cuda-version }} nvidia::cuda-cudart=${{ matrix.cuda-version }} nvidia::cuda-driver-dev=${{ matrix.cuda-version }} conda-forge::ffmpeg=${{ matrix.ffmpeg-version-for-tests }}"
10094
- name: Check env

README.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,12 @@ First, make sure you have a GPU that has NVDEC hardware that can decode the
146146
format you want. Refer to Nvidia's GPU support matrix for more details
147147
[here](https://developer.nvidia.com/video-encode-and-decode-gpu-support-matrix-new).
148148

149-
1. Install CUDA Toolkit. Pytorch and TorchCodec supports CUDA Toolkit
150-
versions 11.8, 12.1 or 12.4. In particular TorchCodec depends on
151-
CUDA libraries libnpp and libnvrtc (which are part of CUDA Toolkit).
149+
1. Install Pytorch corresponding to your CUDA Toolkit using the
150+
[official instructions](https://pytorch.org/get-started/locally/). You'll
151+
need the `libnpp` and `libnvrtc` CUDA libraries, which are usually part of
152+
the CUDA Toolkit.
152153

153-
2. Install Pytorch that corresponds to your CUDA Toolkit version using the
154-
[official instructions](https://pytorch.org/get-started/locally/).
155-
156-
3. Install or compile FFmpeg with NVDEC support.
154+
2. Install or compile FFmpeg with NVDEC support.
157155
TorchCodec with CUDA should work with FFmpeg versions in [5, 7].
158156

159157
If FFmpeg is not already installed, or you need a more recent version, an
@@ -184,13 +182,13 @@ format you want. Refer to Nvidia's GPU support matrix for more details
184182
ffmpeg -hwaccel cuda -hwaccel_output_format cuda -i test/resources/nasa_13013.mp4 -f null -
185183
```
186184

187-
4. Install TorchCodec by passing in an `--index-url` parameter that corresponds
185+
3. Install TorchCodec by passing in an `--index-url` parameter that corresponds
188186
to your CUDA Toolkit version, example:
189187

190188
```bash
191-
# This corresponds to CUDA Toolkit version 12.4. It should be the same one
189+
# This corresponds to CUDA Toolkit version 12.6. It should be the same one
192190
# you used when you installed PyTorch (If you installed PyTorch with pip).
193-
pip install torchcodec --index-url=https://download.pytorch.org/whl/cu124
191+
pip install torchcodec --index-url=https://download.pytorch.org/whl/cu126
194192
```
195193

196194
Note that without passing in the `--index-url` parameter, `pip` installs

0 commit comments

Comments
 (0)