Skip to content

Commit 7fb6536

Browse files
committed
maybe fix something
1 parent 2791490 commit 7fb6536

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.github/workflows/windows_wheel.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ jobs:
4242
strategy:
4343
fail-fast: false
4444
name: Build and Upload Windows wheel
45+
# TODO
46+
# We shouldn't use this, but this is needed for now. Note that this is where we are setting the BUILD_AGAINST_ALL_FFMPEG_FROM_S3 variable currently, we'll have to find a way around that.
4547
uses: nicolashug/test-infra/.github/workflows/build_wheels_windows.yml@build-platform-windows
4648
with:
4749
repository: pytorch/torchcodec
@@ -57,6 +59,7 @@ jobs:
5759
trigger-event: ${{ github.event_name }}
5860
build-platform: "python-build-package"
5961
# build-command: "BUILD_AGAINST_ALL_FFMPEG_FROM_S3=1 python -m build --wheel -vvv --no-isolation"
62+
# TODO see comment above
6063
build-command: "python -m build --wheel -vvv --no-isolation"
6164

6265
install-and-test:

setup.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,11 @@ def copy_extensions_to_source(self):
150150
# dynamically loaded module. For more, see:
151151
# https://stackoverflow.com/a/2339910
152152
extensions = ["dylib", "so"]
153+
elif sys.platform in ("win32", "cygwin"):
154+
extensions = ["dll"]
153155
else:
154156
raise NotImplementedError(
155-
"Platforms other than linux/darwin are not supported yet"
157+
f"Platform {sys.platform} is not supported"
156158
)
157159

158160
for ext in extensions:

0 commit comments

Comments
 (0)