Add VP8 support

Author: NicolasHug

src/torchcodec/_core/BetaCudaDeviceInterface.cpp

@@ -152,9 +152,10 @@ cudaVideoCodec validateCodecSupport(AVCodecID codecId) {
       return cudaVideoCodec_AV1;
     case AV_CODEC_ID_VP9:
       return cudaVideoCodec_VP9;
+    case AV_CODEC_ID_VP8:
+      return cudaVideoCodec_VP8;
     // TODONVDEC P0: support more codecs
     // case AV_CODEC_ID_MPEG4: return cudaVideoCodec_MPEG4;
-    // case AV_CODEC_ID_VP8: return cudaVideoCodec_VP8;
     // case AV_CODEC_ID_MJPEG: return cudaVideoCodec_JPEG;
     default: {
       TORCH_CHECK(false, "Unsupported codec type: ", avcodec_get_name(codecId));

test/resources/testsrc2_vp8.webm

@@ -45,6 +45,7 @@
     SINE_MONO_S32_8000,
     TEST_SRC_2_720P,
     TEST_SRC_2_720P_H265,
+    TEST_SRC_2_720P_VP8,
     TEST_SRC_2_720P_VP9,
     unsplit_device_str,
 )
@@ -1453,14 +1454,18 @@ def test_get_frames_at_tensor_indices(self):
             TEST_SRC_2_720P_H265,
             AV1_VIDEO,
             TEST_SRC_2_720P_VP9,
+            TEST_SRC_2_720P_VP8,
         ),
     )
     @pytest.mark.parametrize("contiguous_indices", (True, False))
     @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
     def test_beta_cuda_interface_get_frame_at(
         self, asset, contiguous_indices, seek_mode
     ):
-        if asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9) and seek_mode == "approximate":
+        if (
+            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
+            and seek_mode == "approximate"
+        ):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
@@ -1496,14 +1501,18 @@ def test_beta_cuda_interface_get_frame_at(
             TEST_SRC_2_720P_H265,
             AV1_VIDEO,
             TEST_SRC_2_720P_VP9,
+            TEST_SRC_2_720P_VP8,
         ),
     )
     @pytest.mark.parametrize("contiguous_indices", (True, False))
     @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
     def test_beta_cuda_interface_get_frames_at(
         self, asset, contiguous_indices, seek_mode
     ):
-        if asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9) and seek_mode == "approximate":
+        if (
+            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
+            and seek_mode == "approximate"
+        ):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
@@ -1540,11 +1549,15 @@ def test_beta_cuda_interface_get_frames_at(
             TEST_SRC_2_720P_H265,
             AV1_VIDEO,
             TEST_SRC_2_720P_VP9,
+            TEST_SRC_2_720P_VP8,
         ),
     )
     @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
     def test_beta_cuda_interface_get_frame_played_at(self, asset, seek_mode):
-        if asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9) and seek_mode == "approximate":
+        if (
+            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
+            and seek_mode == "approximate"
+        ):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
@@ -1577,12 +1590,16 @@ def test_beta_cuda_interface_get_frame_played_at(self, asset, seek_mode):
             BT709_FULL_RANGE,
             TEST_SRC_2_720P_H265,
             TEST_SRC_2_720P_VP9,
+            TEST_SRC_2_720P_VP8,
             AV1_VIDEO,
         ),
     )
     @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
     def test_beta_cuda_interface_get_frames_played_at(self, asset, seek_mode):
-        if asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9) and seek_mode == "approximate":
+        if (
+            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
+            and seek_mode == "approximate"
+        ):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
@@ -1617,11 +1634,15 @@ def test_beta_cuda_interface_get_frames_played_at(self, asset, seek_mode):
             TEST_SRC_2_720P_H265,
             AV1_VIDEO,
             TEST_SRC_2_720P_VP9,
+            TEST_SRC_2_720P_VP8,
         ),
     )
     @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
     def test_beta_cuda_interface_backwards(self, asset, seek_mode):
-        if asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9) and seek_mode == "approximate":
+        if (
+            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
+            and seek_mode == "approximate"
+        ):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)

test/test_decoders.py

@@ -727,3 +727,13 @@ def sample_format(self) -> str:
     },
     frames={0: {}},  # Not needed for now
 )
+
+# ffmpeg -f lavfi -i testsrc2=size=1280x720:rate=30:duration=1 -c:v libvpx -b:v 1M output_vp8.webm
+TEST_SRC_2_720P_VP8 = TestVideo(
+    filename="testsrc2_vp8.webm",
+    default_stream_index=0,
+    stream_infos={
+        0: TestVideoStreamInfo(width=1280, height=720, num_color_channels=3),
+    },
+    frames={0: {}},  # Not needed for now
+)