Minor refac

Author: NicolasHug

test/test_decoders.py

@@ -43,6 +43,7 @@
     SINE_MONO_S32,
     SINE_MONO_S32_44100,
     SINE_MONO_S32_8000,
+    supports_approximate_mode,
     TEST_SRC_2_720P,
     TEST_SRC_2_720P_H265,
     TEST_SRC_2_720P_MPEG4,
@@ -1469,10 +1470,7 @@ def test_get_frames_at_tensor_indices(self):
     def test_beta_cuda_interface_get_frame_at(
         self, asset, contiguous_indices, seek_mode
     ):
-        if (
-            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
-            and seek_mode == "approximate"
-        ):
+        if seek_mode == "approximate" and not supports_approximate_mode(asset):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
@@ -1518,10 +1516,7 @@ def test_beta_cuda_interface_get_frame_at(
     def test_beta_cuda_interface_get_frames_at(
         self, asset, contiguous_indices, seek_mode
     ):
-        if (
-            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
-            and seek_mode == "approximate"
-        ):
+        if seek_mode == "approximate" and not supports_approximate_mode(asset):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
@@ -1565,10 +1560,7 @@ def test_beta_cuda_interface_get_frames_at(
     )
     @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
     def test_beta_cuda_interface_get_frame_played_at(self, asset, seek_mode):
-        if (
-            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
-            and seek_mode == "approximate"
-        ):
+        if seek_mode == "approximate" and not supports_approximate_mode(asset):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
@@ -1609,10 +1601,7 @@ def test_beta_cuda_interface_get_frame_played_at(self, asset, seek_mode):
     )
     @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
     def test_beta_cuda_interface_get_frames_played_at(self, asset, seek_mode):
-        if (
-            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
-            and seek_mode == "approximate"
-        ):
+        if seek_mode == "approximate" and not supports_approximate_mode(asset):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)
@@ -1654,10 +1643,7 @@ def test_beta_cuda_interface_get_frames_played_at(self, asset, seek_mode):
     )
     @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
     def test_beta_cuda_interface_backwards(self, asset, seek_mode):
-        if (
-            asset in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)
-            and seek_mode == "approximate"
-        ):
+        if seek_mode == "approximate" and not supports_approximate_mode(asset):
             pytest.skip("asset doesn't work with approximate mode")
 
         ref_decoder = VideoDecoder(asset.path, device="cuda", seek_mode=seek_mode)

test/utils.py

@@ -747,3 +747,10 @@ def sample_format(self) -> str:
     },
     frames={0: {}},  # Not needed for now
 )
+
+
+def supports_approximate_mode(asset: TestVideo) -> bool:
+    # TODONVDEC P2: open an issue about his. That's actually not related to
+    # NVDEC at all, those don't support approximate mode because they don't set
+    # a duration. CPU decoder fails too!
+    return asset not in (AV1_VIDEO, TEST_SRC_2_720P_VP9, TEST_SRC_2_720P_VP8)