simplify metadata assert, only assert in to_file again

Author: Dan-Flores

test/test_encoders.py

@@ -992,9 +992,6 @@ def test_video_encoder_against_ffmpeg_cli(
                 preset=preset,
             )
             encoder_frames = self.decode(encoded_output).data
-            # Write tensor to file to check with ffprobe
-            with open(encoder_output_path, "wb") as f:
-                f.write(encoded_output.numpy().tobytes())
         elif method == "to_file_like":
             file_like = io.BytesIO()
             encoder.to_file_like(
@@ -1005,9 +1002,6 @@ def test_video_encoder_against_ffmpeg_cli(
                 preset=preset,
             )
             encoder_frames = self.decode(file_like.getvalue()).data
-            # Write file_like to file to check with ffprobe
-            with open(encoder_output_path, "wb") as f:
-                f.write(file_like.getvalue())
         else:
             raise ValueError(f"Unknown method: {method}")
 
@@ -1025,17 +1019,17 @@ def test_video_encoder_against_ffmpeg_cli(
             )
 
         # Check that video metadata is the same
-        fields = ["duration", "duration_ts", "r_frame_rate", "nb_frames"]
-        ffmpeg_metadata = self._get_video_metadata(
-            ffmpeg_encoded_path,
-            fields=fields,
-        )
-        encoder_metadata = self._get_video_metadata(
-            encoder_output_path,
-            fields=fields,
-        )
-        for key in ffmpeg_metadata:
-            assert ffmpeg_metadata[key] == encoder_metadata[key]
+        if method == "to_file":
+            fields = ["duration", "duration_ts", "r_frame_rate", "nb_frames"]
+            ffmpeg_metadata = self._get_video_metadata(
+                ffmpeg_encoded_path,
+                fields=fields,
+            )
+            encoder_metadata = self._get_video_metadata(
+                encoder_output_path,
+                fields=fields,
+            )
+            assert ffmpeg_metadata == encoder_metadata
 
     def test_to_file_like_custom_file_object(self):
         """Test to_file_like with a custom file-like object that implements write and seek."""