address feedback

Author: Molly Xu

src/torchcodec/_core/_metadata.py

@@ -52,7 +52,7 @@ def __repr__(self):
         return s
 
 
-@dataclass(repr=False)
+@dataclass
 class VideoStreamMetadata(StreamMetadata):
     """Metadata of a single video stream."""
 
@@ -107,6 +107,9 @@ class VideoStreamMetadata(StreamMetadata):
     if :term:`scan` was performed, computes from
     num_frames and duration, otherwise uses header value."""
 
+    def __repr__(self):
+        return super().__repr__()
+
 
 @dataclass
 class AudioStreamMetadata(StreamMetadata):

test/test_decoders.py

@@ -6,9 +6,7 @@
 
 import contextlib
 import gc
-import json
 from functools import partial
-from unittest.mock import patch
 
 import numpy
 import pytest
@@ -877,61 +875,6 @@ def test_get_frames_in_range_slice_indices_syntax(self, device, seek_mode):
         ).to(device)
         assert_frames_equal(frames387_None.data, reference_frame387_389)
 
-    @pytest.mark.parametrize("device", all_supported_devices())
-    @pytest.mark.parametrize("seek_mode", ("exact", "approximate"))
-    @patch("torchcodec._core._metadata._get_stream_json_metadata")
-    def test_get_frames_with_missing_num_frames_metadata(
-        self, mock_get_stream_json_metadata, device, seek_mode
-    ):
-        # Create a mock stream_dict to test that initializing VideoDecoder without
-        # num_frames_from_header and num_frames_from_content calculates num_frames
-        # using the average_fps and duration_seconds metadata.
-        mock_stream_dict = {
-            "averageFpsFromHeader": 29.97003,
-            "beginStreamSecondsFromContent": 0.0,
-            "beginStreamSecondsFromHeader": 0.0,
-            "bitRate": 128783.0,
-            "codec": "h264",
-            "durationSecondsFromHeader": 13.013,
-            "endStreamSecondsFromContent": 13.013,
-            "width": 480,
-            "height": 270,
-            "mediaType": "video",
-            "numFramesFromHeader": None,
-            "numFramesFromContent": None,
-            "beginStreamSeconds": 0.0,
-            "durationSeconds": 13.013,
-            "endStreamSeconds": 13.013,
-            "numFrames": int(29.97003 * 13.013),  # Calculated from fps * duration
-            "averageFps": 29.97003,
-        }
-        # Set the return value of the mock to be the mock_stream_dict
-        mock_get_stream_json_metadata.return_value = json.dumps(mock_stream_dict)
-
-        decoder, device = make_video_decoder(
-            NASA_VIDEO.path,
-            stream_index=3,
-            device=device,
-            seek_mode=seek_mode,
-        )
-
-        assert decoder.metadata.num_frames_from_header is None
-        assert decoder.metadata.num_frames_from_content is None
-        assert decoder.metadata.duration_seconds is not None
-        assert decoder.metadata.average_fps is not None
-        assert decoder.metadata.num_frames == int(
-            decoder.metadata.duration_seconds * decoder.metadata.average_fps
-        )
-        assert len(decoder) == 390
-
-        # Test get_frames_in_range Python logic which uses the num_frames metadata mocked earlier.
-        # The frame is read at the C++ level.
-        ref_frames9 = NASA_VIDEO.get_frame_data_by_range(
-            start=9, stop=10, stream_index=3
-        ).to(device)
-        frames9 = decoder.get_frames_in_range(start=9, stop=10)
-        assert_frames_equal(ref_frames9, frames9.data)
-
     @pytest.mark.parametrize("dimension_order", ["NCHW", "NHWC"])
     @pytest.mark.parametrize(
         "frame_getter",