wtf

Author: NicolasHug

pyproject.toml

@@ -14,7 +14,7 @@ GitHub = "https://github.com/pytorch/torchcodec"
 Documentation = "https://pytorch.org/torchcodec/stable/index.html"
 
 [tool.setuptools.dynamic]
-version = {attr = "torchcodec.__version__"}
+version = {file = "version.txt"}
 
 [build-system]
 requires = ["setuptools>=61.0"]

setup.py

@@ -173,15 +173,16 @@ def copy_extensions_to_source(self):
 
 
 def get_version():
-    # BUILD_VERSION is set by the `test-infra` build jobs. It typically is
-    # the content of `version.txt` plus some suffix like "+cpu" or "+cu112".
-    # See
-    # https://github.com/pytorch/test-infra/blob/61e6da7a6557152eb9879e461a26ad667c15f0fd/tools/pkg-helpers/pytorch_pkg_helpers/version.py#L113
-    version = os.getenv("BUILD_VERSION")
-    if not version:
+    if version := os.getenv("BUILD_VERSION"):
+        # BUILD_VERSION is set by the `test-infra` build jobs. It typically is
+        # the content of `version.txt` plus some suffix like "+cpu" or "+cu112".
+        # See
+        # https://github.com/pytorch/test-infra/blob/61e6da7a6557152eb9879e461a26ad667c15f0fd/tools/pkg-helpers/pytorch_pkg_helpers/version.py#L113
+        with open(_ROOT_DIR / "version.txt", "w") as f:
+            f.write(f"{version}")
+    else:
         with open(_ROOT_DIR / "version.txt") as f:
             version = f.readline().strip()
-
         try:
             sha = (
                 subprocess.check_output(
@@ -194,16 +195,12 @@ def get_version():
         except Exception:
             print("INFO: Didn't find sha. Is this a git repo?")
 
-    return version
-
+        f.write(f"__version__ = '{version}\n")
 
-def write_version_file(version):
-    with open(_ROOT_DIR / "src/torchcodec/version.py", "w") as f:
-        f.write(f"def _get_version(): return '{version}'\n")
+    return version
 
 
 version = get_version()
-write_version_file(version)
 
 setup(
     version=version,

src/torchcodec/__init__.py

@@ -9,9 +9,4 @@
 from ._frame import Frame, FrameBatch  # usort:skip # noqa
 from . import decoders, samplers  # noqa
 
-from .version import _get_version
-
-try:
-    __version__ = _get_version()
-except Exception:
-    pass
+from .version import __version__

test/test_version.py

@@ -2,4 +2,5 @@
 
 
 def test_version():
-    assert torchcodec.__version__ != "0.0.0"
+    assert "+cpu" not in torchcodec.__version__
+    assert "+cu" not in torchcodec.__version__