incorporate suggestions

Author: Daniel Flores

src/torchcodec/_core/FFMPEGCommon.cpp

@@ -7,7 +7,6 @@
 #include "src/torchcodec/_core/FFMPEGCommon.h"
 
 #include <c10/util/Exception.h>
-
 extern "C" {
 #include <libavfilter/avfilter.h>
 #include <libavfilter/buffersink.h>
@@ -381,18 +380,21 @@ SwrContext* createSwrContext(
 
 AVFilterContext* createBuffersinkFilter(
     AVFilterGraph* filterGraph,
-    const char* name,
     enum AVPixelFormat outputFormat) {
   const AVFilter* buffersink = avfilter_get_by_name("buffersink");
   TORCH_CHECK(buffersink != nullptr, "Failed to get buffersink filter.");
 
   AVFilterContext* sinkContext = nullptr;
   int status;
+  const char* filterName = "out";
+
+  enum AVPixelFormat pix_fmts[] = {outputFormat, AV_PIX_FMT_NONE};
 
-// av_opt_set_int_list was replaced by av_opt_set() in FFmpeg 8.
+// av_opt_set_int_list was replaced by av_opt_set_array() in FFmpeg 8.
 #if LIBAVUTIL_VERSION_MAJOR >= 60 // FFmpeg >= 8
   // Output options like pixel_formats must be set before filter init
-  sinkContext = avfilter_graph_alloc_filter(filterGraph, buffersink, name);
+  sinkContext =
+      avfilter_graph_alloc_filter(filterGraph, buffersink, filterName);
   TORCH_CHECK(
       sinkContext != nullptr, "Failed to allocate buffersink filter context.");
 
@@ -403,7 +405,7 @@ AVFilterContext* createBuffersinkFilter(
       0, // start_elem
       1, // nb_elems
       AV_OPT_TYPE_PIXEL_FMT,
-      &outputFormat);
+      pix_fmts);
   TORCH_CHECK(
       status >= 0,
       "Failed to set pixel format for buffersink filter: ",
@@ -417,14 +419,12 @@ AVFilterContext* createBuffersinkFilter(
 #else // FFmpeg <= 7
   // For older FFmpeg versions, create filter and then set options
   status = avfilter_graph_create_filter(
-      &sinkContext, buffersink, name, nullptr, nullptr, filterGraph);
+      &sinkContext, buffersink, filterName, nullptr, nullptr, filterGraph);
   TORCH_CHECK(
       status >= 0,
       "Failed to create buffersink filter: ",
       getFFMPEGErrorStringFromErrorCode(status));
 
-  enum AVPixelFormat pix_fmts[] = {outputFormat, AV_PIX_FMT_NONE};
-
   status = av_opt_set_int_list(
       sinkContext,
       "pix_fmts",

src/torchcodec/_core/FFMPEGCommon.h

@@ -239,7 +239,6 @@ int64_t computeSafeDuration(
 
 AVFilterContext* createBuffersinkFilter(
     AVFilterGraph* filterGraph,
-    const char* name,
     enum AVPixelFormat outputFormat);
 
 } // namespace facebook::torchcodec

src/torchcodec/_core/FilterGraph.cpp

@@ -93,8 +93,8 @@ FilterGraph::FilterGraph(
       "Failed to create filter graph : ",
       getFFMPEGErrorStringFromErrorCode(status));
 
-  sinkContext_ = createBuffersinkFilter(
-      filterGraph_.get(), "out", filtersContext.outputFormat);
+  sinkContext_ =
+      createBuffersinkFilter(filterGraph_.get(), filtersContext.outputFormat);
   TORCH_CHECK(
       sinkContext_ != nullptr, "Failed to create and configure buffersink");