Skip to content

Commit c6c30ce

Browse files
NicolasHugNicolasHug
committed
Comment-out some workflows
1 parent b46e5ac commit c6c30ce

File tree

6 files changed

+457
-457
lines changed

6 files changed

+457
-457
lines changed

‎.github/workflows/cpp_tests.yaml‎

Lines changed: 68 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -1,73 +1,73 @@
1-
name: CPP tests
1+
# name: CPP tests
22

3-
on:
4-
push:
5-
branches: [ main ]
6-
pull_request:
3+
# on:
4+
# push:
5+
# branches: [ main ]
6+
# pull_request:
77

8-
concurrency:
9-
group: unit-test${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}
10-
cancel-in-progress: true
8+
# concurrency:
9+
# group: unit-test${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}
10+
# cancel-in-progress: true
1111

12-
defaults:
13-
run:
14-
shell: bash -l -eo pipefail {0}
12+
# defaults:
13+
# run:
14+
# shell: bash -l -eo pipefail {0}
1515

16-
jobs:
17-
Cpp-tests:
18-
runs-on: ubuntu-latest
19-
strategy:
20-
fail-fast: false
21-
matrix:
22-
ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '6.1.1', '7.0.1']
23-
steps:
24-
- name: Check out repo
25-
uses: actions/checkout@v3
26-
- name: Setup conda env
27-
uses: conda-incubator/setup-miniconda@v3
28-
with:
29-
auto-update-conda: true
30-
# Using miniforge instead of miniconda ensures that the default
31-
# conda channel is conda-forge instead of main/default. This ensures
32-
# ABI consistency between dependencies:
33-
# https://conda-forge.org/docs/user/transitioning_from_defaults/
34-
miniforge-version: latest
35-
activate-environment: test
36-
python-version: '3.12'
37-
- name: Update pip
38-
run: python -m pip install --upgrade pip
39-
- name: Install torch dependencies
40-
run: |
41-
python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu
42-
- name: Install ffmpeg, pkg-config and pybind11
43-
run: |
44-
conda install "ffmpeg=${{ matrix.ffmpeg-version-for-tests }}" pkg-config pybind11 -c conda-forge
45-
ffmpeg -version
46-
- name: Build and run C++ tests
47-
run: |
48-
# Note: we're not setting BUILD_AGAINST_ALL_FFMPEG_FROM_S3 here, so
49-
# we're building libtorchcodec against the installed FFmpeg version
50-
# (from conda-forge) instead of building against our pre-built non-GPL
51-
# FFmpeg libraries.
52-
# The reason we need this is because the C++ tests decode x264 files.
53-
# x264 support is not LGPL, os it is not supported by our
54-
# pre-built non-GPL FFmpeg libraries. And if we were to build against
55-
# those, this is also what the tests would be loading at run time,
56-
# then failing when we try to decode x264.
57-
# To remediate that, we build against the FFmpeg that we installed
58-
# from conda-forge (which is able to decode x264), and that's also
59-
# what gets loaded at run time.
60-
# The Python tests are also decoding x264 files, and are built against
61-
# our non-GPL FFmpeg. And yet they pass. This is because in Python
62-
# we're able to distinguish between build-time (non-GPL FFmpeg) and
63-
# run time (conda-forge FFmpeg).
16+
# jobs:
17+
# Cpp-tests:
18+
# runs-on: ubuntu-latest
19+
# strategy:
20+
# fail-fast: false
21+
# matrix:
22+
# ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '6.1.1', '7.0.1']
23+
# steps:
24+
# - name: Check out repo
25+
# uses: actions/checkout@v3
26+
# - name: Setup conda env
27+
# uses: conda-incubator/setup-miniconda@v3
28+
# with:
29+
# auto-update-conda: true
30+
# # Using miniforge instead of miniconda ensures that the default
31+
# # conda channel is conda-forge instead of main/default. This ensures
32+
# # ABI consistency between dependencies:
33+
# # https://conda-forge.org/docs/user/transitioning_from_defaults/
34+
# miniforge-version: latest
35+
# activate-environment: test
36+
# python-version: '3.12'
37+
# - name: Update pip
38+
# run: python -m pip install --upgrade pip
39+
# - name: Install torch dependencies
40+
# run: |
41+
# python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu
42+
# - name: Install ffmpeg, pkg-config and pybind11
43+
# run: |
44+
# conda install "ffmpeg=${{ matrix.ffmpeg-version-for-tests }}" pkg-config pybind11 -c conda-forge
45+
# ffmpeg -version
46+
# - name: Build and run C++ tests
47+
# run: |
48+
# # Note: we're not setting BUILD_AGAINST_ALL_FFMPEG_FROM_S3 here, so
49+
# # we're building libtorchcodec against the installed FFmpeg version
50+
# # (from conda-forge) instead of building against our pre-built non-GPL
51+
# # FFmpeg libraries.
52+
# # The reason we need this is because the C++ tests decode x264 files.
53+
# # x264 support is not LGPL, os it is not supported by our
54+
# # pre-built non-GPL FFmpeg libraries. And if we were to build against
55+
# # those, this is also what the tests would be loading at run time,
56+
# # then failing when we try to decode x264.
57+
# # To remediate that, we build against the FFmpeg that we installed
58+
# # from conda-forge (which is able to decode x264), and that's also
59+
# # what gets loaded at run time.
60+
# # The Python tests are also decoding x264 files, and are built against
61+
# # our non-GPL FFmpeg. And yet they pass. This is because in Python
62+
# # we're able to distinguish between build-time (non-GPL FFmpeg) and
63+
# # run time (conda-forge FFmpeg).
6464

65-
build_tests_dir="${PWD}/build_tests"
66-
mkdir $build_tests_dir
67-
pushd $build_tests_dir
68-
TORCH_PATH=$(python -c "import pathlib, torch; print(pathlib.Path(torch.__path__[0]))")
69-
Torch_DIR="${TORCH_PATH}/share/cmake/Torch"
70-
cmake .. -DTorch_DIR=$Torch_DIR -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON -DCMAKE_VERBOSE_MAKEFILE=ON
71-
cmake --build .
72-
ctest --output-on-failure
73-
popd
65+
# build_tests_dir="${PWD}/build_tests"
66+
# mkdir $build_tests_dir
67+
# pushd $build_tests_dir
68+
# TORCH_PATH=$(python -c "import pathlib, torch; print(pathlib.Path(torch.__path__[0]))")
69+
# Torch_DIR="${TORCH_PATH}/share/cmake/Torch"
70+
# cmake .. -DTorch_DIR=$Torch_DIR -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON -DCMAKE_VERBOSE_MAKEFILE=ON
71+
# cmake --build .
72+
# ctest --output-on-failure
73+
# popd

‎.github/workflows/docs.yaml‎

Lines changed: 109 additions & 109 deletions
Original file line numberDiff line numberDiff line change
@@ -1,116 +1,116 @@
1-
name: Docs
1+
# name: Docs
22

3-
on:
4-
push:
5-
branches: [ main ]
6-
pull_request:
3+
# on:
4+
# push:
5+
# branches: [ main ]
6+
# pull_request:
77

8-
permissions:
9-
id-token: write
10-
contents: write
8+
# permissions:
9+
# id-token: write
10+
# contents: write
1111

12-
defaults:
13-
run:
14-
shell: bash -l -eo pipefail {0}
12+
# defaults:
13+
# run:
14+
# shell: bash -l -eo pipefail {0}
1515

16-
jobs:
17-
generate-matrix:
18-
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
19-
with:
20-
package-type: wheel
21-
os: linux
22-
test-infra-repository: pytorch/test-infra
23-
test-infra-ref: main
24-
with-cpu: disable
25-
with-xpu: disable
26-
with-rocm: disable
27-
with-cuda: enable
28-
build-python-only: "disable"
29-
build:
30-
needs: generate-matrix
31-
strategy:
32-
fail-fast: false
33-
name: Build and Upload wheel
34-
uses: pytorch/test-infra/.github/workflows/build_wheels_linux.yml@main
35-
with:
36-
repository: pytorch/torchcodec
37-
ref: ""
38-
test-infra-repository: pytorch/test-infra
39-
test-infra-ref: main
40-
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
41-
pre-script: packaging/pre_build_script.sh
42-
post-script: packaging/post_build_script.sh
43-
smoke-test-script: packaging/fake_smoke_test.py
44-
package-name: torchcodec
45-
trigger-event: ${{ github.event_name }}
46-
build-platform: "python-build-package"
47-
build-command: "BUILD_AGAINST_ALL_FFMPEG_FROM_S3=1 ENABLE_CUDA=1 python -m build --wheel -vvv --no-isolation"
16+
# jobs:
17+
# generate-matrix:
18+
# uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
19+
# with:
20+
# package-type: wheel
21+
# os: linux
22+
# test-infra-repository: pytorch/test-infra
23+
# test-infra-ref: main
24+
# with-cpu: disable
25+
# with-xpu: disable
26+
# with-rocm: disable
27+
# with-cuda: enable
28+
# build-python-only: "disable"
29+
# build:
30+
# needs: generate-matrix
31+
# strategy:
32+
# fail-fast: false
33+
# name: Build and Upload wheel
34+
# uses: pytorch/test-infra/.github/workflows/build_wheels_linux.yml@main
35+
# with:
36+
# repository: pytorch/torchcodec
37+
# ref: ""
38+
# test-infra-repository: pytorch/test-infra
39+
# test-infra-ref: main
40+
# build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
41+
# pre-script: packaging/pre_build_script.sh
42+
# post-script: packaging/post_build_script.sh
43+
# smoke-test-script: packaging/fake_smoke_test.py
44+
# package-name: torchcodec
45+
# trigger-event: ${{ github.event_name }}
46+
# build-platform: "python-build-package"
47+
# build-command: "BUILD_AGAINST_ALL_FFMPEG_FROM_S3=1 ENABLE_CUDA=1 python -m build --wheel -vvv --no-isolation"
4848

49-
build-docs:
50-
runs-on: linux.4xlarge.nvidia.gpu
51-
strategy:
52-
fail-fast: false
53-
matrix:
54-
# 3.9 corresponds to the minimum python version for which we build
55-
# the wheel unless the label cliflow/binaries/all is present in the
56-
# PR.
57-
python-version: ['3.9']
58-
cuda-version: ['12.6']
59-
ffmpeg-version-for-tests: ['7']
60-
container:
61-
image: "pytorch/manylinux2_28-builder:cuda${{ matrix.cuda-version }}"
62-
options: "--gpus all -e NVIDIA_DRIVER_CAPABILITIES=video,compute,utility"
63-
needs: build
64-
steps:
65-
- name: Setup env vars
66-
run: |
67-
cuda_version_without_periods=$(echo "${{ matrix.cuda-version }}" | sed 's/\.//g')
68-
echo cuda_version_without_periods=${cuda_version_without_periods} >> $GITHUB_ENV
69-
python_version_without_periods=$(echo "${{ matrix.python-version }}" | sed 's/\.//g')
70-
echo python_version_without_periods=${python_version_without_periods} >> $GITHUB_ENV
71-
- uses: actions/download-artifact@v4
72-
with:
73-
name: pytorch_torchcodec__${{ matrix.python-version }}_cu${{ env.cuda_version_without_periods }}_x86_64
74-
path: pytorch/torchcodec/dist/
75-
- name: Setup miniconda using test-infra
76-
uses: pytorch/test-infra/.github/actions/setup-miniconda@main
77-
with:
78-
python-version: ${{ matrix.python-version }}
79-
# We install conda packages at the start because otherwise conda may have conflicts with dependencies.
80-
default-packages: "nvidia/label/cuda-${{ matrix.cuda-version }}.0::libnpp nvidia::cuda-nvrtc=${{ matrix.cuda-version }} nvidia::cuda-toolkit=${{ matrix.cuda-version }} nvidia::cuda-cudart=${{ matrix.cuda-version }} nvidia::cuda-driver-dev=${{ matrix.cuda-version }} conda-forge::ffmpeg=${{ matrix.ffmpeg-version-for-tests }}"
81-
- name: Check env
82-
run: |
83-
${CONDA_RUN} env
84-
${CONDA_RUN} conda info
85-
${CONDA_RUN} nvidia-smi
86-
${CONDA_RUN} conda list
87-
- name: Assert ffmpeg exists
88-
run: |
89-
${CONDA_RUN} ffmpeg -buildconf
90-
- name: Update pip
91-
run: ${CONDA_RUN} python -m pip install --upgrade pip
92-
- name: Install PyTorch
93-
run: |
94-
${CONDA_RUN} python -m pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu${{ env.cuda_version_without_periods }}
95-
${CONDA_RUN} python -c 'import torch; print(f"{torch.__version__}"); print(f"{torch.__file__}"); print(f"{torch.cuda.is_available()=}")'
96-
- name: Install torchcodec from the wheel
97-
run: |
98-
wheel_path=`find pytorch/torchcodec/dist -type f -name "*cu${{ env.cuda_version_without_periods }}-cp${{ env.python_version_without_periods }}*.whl"`
99-
echo Installing $wheel_path
100-
${CONDA_RUN} python -m pip install $wheel_path -vvv
49+
# build-docs:
50+
# runs-on: linux.4xlarge.nvidia.gpu
51+
# strategy:
52+
# fail-fast: false
53+
# matrix:
54+
# # 3.9 corresponds to the minimum python version for which we build
55+
# # the wheel unless the label cliflow/binaries/all is present in the
56+
# # PR.
57+
# python-version: ['3.9']
58+
# cuda-version: ['12.6']
59+
# ffmpeg-version-for-tests: ['7']
60+
# container:
61+
# image: "pytorch/manylinux2_28-builder:cuda${{ matrix.cuda-version }}"
62+
# options: "--gpus all -e NVIDIA_DRIVER_CAPABILITIES=video,compute,utility"
63+
# needs: build
64+
# steps:
65+
# - name: Setup env vars
66+
# run: |
67+
# cuda_version_without_periods=$(echo "${{ matrix.cuda-version }}" | sed 's/\.//g')
68+
# echo cuda_version_without_periods=${cuda_version_without_periods} >> $GITHUB_ENV
69+
# python_version_without_periods=$(echo "${{ matrix.python-version }}" | sed 's/\.//g')
70+
# echo python_version_without_periods=${python_version_without_periods} >> $GITHUB_ENV
71+
# - uses: actions/download-artifact@v4
72+
# with:
73+
# name: pytorch_torchcodec__${{ matrix.python-version }}_cu${{ env.cuda_version_without_periods }}_x86_64
74+
# path: pytorch/torchcodec/dist/
75+
# - name: Setup miniconda using test-infra
76+
# uses: pytorch/test-infra/.github/actions/setup-miniconda@main
77+
# with:
78+
# python-version: ${{ matrix.python-version }}
79+
# # We install conda packages at the start because otherwise conda may have conflicts with dependencies.
80+
# default-packages: "nvidia/label/cuda-${{ matrix.cuda-version }}.0::libnpp nvidia::cuda-nvrtc=${{ matrix.cuda-version }} nvidia::cuda-toolkit=${{ matrix.cuda-version }} nvidia::cuda-cudart=${{ matrix.cuda-version }} nvidia::cuda-driver-dev=${{ matrix.cuda-version }} conda-forge::ffmpeg=${{ matrix.ffmpeg-version-for-tests }}"
81+
# - name: Check env
82+
# run: |
83+
# ${CONDA_RUN} env
84+
# ${CONDA_RUN} conda info
85+
# ${CONDA_RUN} nvidia-smi
86+
# ${CONDA_RUN} conda list
87+
# - name: Assert ffmpeg exists
88+
# run: |
89+
# ${CONDA_RUN} ffmpeg -buildconf
90+
# - name: Update pip
91+
# run: ${CONDA_RUN} python -m pip install --upgrade pip
92+
# - name: Install PyTorch
93+
# run: |
94+
# ${CONDA_RUN} python -m pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu${{ env.cuda_version_without_periods }}
95+
# ${CONDA_RUN} python -c 'import torch; print(f"{torch.__version__}"); print(f"{torch.__file__}"); print(f"{torch.cuda.is_available()=}")'
96+
# - name: Install torchcodec from the wheel
97+
# run: |
98+
# wheel_path=`find pytorch/torchcodec/dist -type f -name "*cu${{ env.cuda_version_without_periods }}-cp${{ env.python_version_without_periods }}*.whl"`
99+
# echo Installing $wheel_path
100+
# ${CONDA_RUN} python -m pip install $wheel_path -vvv
101101

102-
- name: Check out repo
103-
uses: actions/checkout@v3
102+
# - name: Check out repo
103+
# uses: actions/checkout@v3
104104

105-
- name: Install doc dependencies
106-
run: |
107-
cd docs
108-
${CONDA_RUN} python -m pip install -r requirements.txt
109-
- name: Build docs
110-
run: |
111-
cd docs
112-
${CONDA_RUN} make html
113-
- uses: actions/upload-artifact@v4
114-
with:
115-
name: Built-Docs
116-
path: docs/build/html/
105+
# - name: Install doc dependencies
106+
# run: |
107+
# cd docs
108+
# ${CONDA_RUN} python -m pip install -r requirements.txt
109+
# - name: Build docs
110+
# run: |
111+
# cd docs
112+
# ${CONDA_RUN} make html
113+
# - uses: actions/upload-artifact@v4
114+
# with:
115+
# name: Built-Docs
116+
# path: docs/build/html/

0 commit comments

Comments
 (0)