Skip to content

Commit da1796a

Browse files
committed
Put back FFmpeg4
1 parent de59431 commit da1796a

File tree

4 files changed

+3
-9
lines changed

4 files changed

+3
-9
lines changed

.github/workflows/cpp_tests.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ jobs:
2121
matrix:
2222
# TODO put back 6.1.1. See
2323
# https://github.com/pytorch/torchcodec/issues/518
24-
# TODO
25-
# ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '7.0.1']
26-
ffmpeg-version-for-tests: ['5.1.2', '7.0.1']
24+
ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '7.0.1']
2725
steps:
2826
- name: Check out repo
2927
uses: actions/checkout@v3

.github/workflows/linux_cuda_wheel.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ jobs:
6868
python-version: ['3.9']
6969
cuda-version: ['11.8', '12.6', '12.8']
7070
# TODO: put back ffmpeg 5 https://github.com/pytorch/torchcodec/issues/325
71-
# TODO
72-
ffmpeg-version-for-tests: ['6', '7']
71+
ffmpeg-version-for-tests: ['4.4.2', '6', '7']
7372

7473
container:
7574
image: "pytorch/manylinux2_28-builder:cuda${{ matrix.cuda-version }}"

.github/workflows/linux_wheel.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,7 @@ jobs:
6262
fail-fast: false
6363
matrix:
6464
python-version: ['3.9']
65-
# TODO
66-
# ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '6.1.1', '7.0.1']
67-
ffmpeg-version-for-tests: ['5.1.2', '6.1.1', '7.0.1']
65+
ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '6.1.1', '7.0.1']
6866
needs: build
6967
steps:
7068
- uses: actions/download-artifact@v4

src/torchcodec/decoders/_core/VideoDecoder.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,6 @@ void VideoDecoder::initializeDecoder() {
174174
AVSampleFormat format =
175175
static_cast<AVSampleFormat>(avStream->codecpar->format);
176176
streamMetadata.sampleFormat = av_get_sample_fmt_name(format);
177-
std::cout << "FUCK " << *streamMetadata.sampleFormat << "AFEFMEMFMFE " << std::endl;
178177
containerMetadata_.numAudioStreams++;
179178
}
180179

0 commit comments

Comments
 (0)