Skip to content

Commit e022f6a

Browse files
committed
Remove unnecessary get_frames functions, add comment
1 parent 3075975 commit e022f6a

File tree

1 file changed

+2
-23
lines changed

1 file changed

+2
-23
lines changed

test/test_decoders.py

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -782,35 +782,14 @@ def test_get_frames_with_missing_num_frames_metadata(
782782
)
783783
assert len(decoder) == 390
784784

785-
# Test get_frames_in_range
785+
# Test get_frames_in_range Python logic which uses the num_frames metadata mocked earlier.
786+
# The frame is read at the C++ level.
786787
ref_frames9 = NASA_VIDEO.get_frame_data_by_range(
787788
start=9, stop=10, stream_index=3
788789
).to(device)
789790
frames9 = decoder.get_frames_in_range(start=9, stop=10)
790791
assert_frames_equal(ref_frames9, frames9.data)
791792

792-
# Test get_frame_at
793-
ref_frame9 = NASA_VIDEO.get_frame_data_by_index(9, stream_index=3).to(device)
794-
frame9 = decoder.get_frame_at(9)
795-
assert_frames_equal(ref_frame9, frame9.data)
796-
797-
# Test get_frames_at
798-
indices = [0, 1, 25, 35]
799-
ref_frames = [
800-
NASA_VIDEO.get_frame_data_by_index(i, stream_index=3).to(device)
801-
for i in indices
802-
]
803-
frames = decoder.get_frames_at(indices)
804-
for ref, frame in zip(ref_frames, frames.data):
805-
assert_frames_equal(ref, frame)
806-
807-
# Test get_frames_played_in_range to get all frames
808-
assert decoder.metadata.end_stream_seconds is not None
809-
all_frames = decoder.get_frames_played_in_range(
810-
decoder.metadata.begin_stream_seconds, decoder.metadata.end_stream_seconds
811-
)
812-
assert_frames_equal(all_frames.data, decoder[:])
813-
814793
@pytest.mark.parametrize("dimension_order", ["NCHW", "NHWC"])
815794
@pytest.mark.parametrize(
816795
"frame_getter",

0 commit comments

Comments
 (0)