Skip to content

Commit e85f26a

Browse files
author
Daniel Flores
committed
fix audio tests by updating mp3 duration seconds
1 parent ad19ecd commit e85f26a

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed

test/test_decoders.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1699,8 +1699,13 @@ def test_metadata(self, asset):
16991699
== decoder.metadata.stream_index
17001700
== asset.default_stream_index
17011701
)
1702+
1703+
expected_duration_seconds_from_header = asset.duration_seconds
1704+
if asset == NASA_AUDIO_MP3 and get_ffmpeg_major_version() >= 8:
1705+
expected_duration_seconds_from_header = 13.056
1706+
17021707
assert decoder.metadata.duration_seconds_from_header == pytest.approx(
1703-
asset.duration_seconds
1708+
expected_duration_seconds_from_header
17041709
)
17051710
assert decoder.metadata.sample_rate == asset.sample_rate
17061711
assert decoder.metadata.num_channels == asset.num_channels

test/test_metadata.py

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,16 @@ def test_get_metadata_audio_file(metadata_getter):
131131
best_audio_stream_metadata = metadata.streams[metadata.best_audio_stream_index]
132132
assert isinstance(best_audio_stream_metadata, AudioStreamMetadata)
133133
assert best_audio_stream_metadata is metadata.best_audio_stream
134-
assert best_audio_stream_metadata.duration_seconds_from_header == 13.248
134+
135+
ffmpeg_major_version = get_ffmpeg_major_version()
136+
expected_duration_seconds_from_header = (
137+
13.056 if ffmpeg_major_version >= 8 else 13.248
138+
)
139+
140+
assert (
141+
best_audio_stream_metadata.duration_seconds_from_header
142+
== expected_duration_seconds_from_header
143+
)
135144
assert best_audio_stream_metadata.begin_stream_seconds_from_header == 0.138125
136145
assert best_audio_stream_metadata.bit_rate == 64000
137146
assert best_audio_stream_metadata.codec == "mp3"
@@ -281,11 +290,15 @@ def test_repr():
281290
average_fps: 29.97002997002997
282291
"""
283292
)
293+
ffmpeg_major_version = get_ffmpeg_major_version()
294+
expected_duration_seconds_from_header = (
295+
13.056 if ffmpeg_major_version >= 8 else 13.248
296+
)
284297

285298
assert (
286299
str(AudioDecoder(NASA_AUDIO_MP3.path).metadata)
287-
== """AudioStreamMetadata:
288-
duration_seconds_from_header: 13.248
300+
== f"""AudioStreamMetadata:
301+
duration_seconds_from_header: {expected_duration_seconds_from_header}
289302
begin_stream_seconds_from_header: 0.138125
290303
bit_rate: 64000.0
291304
codec: mp3

0 commit comments

Comments
 (0)