Skip to content

Commit ea86677

Browse files
committed
Merge branch 'main' of github.com:pytorch/torchcodec into nvdec-av1
2 parents 29e72f9 + b1af8ce commit ea86677

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/torchcodec/_core/BetaCudaDeviceInterface.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ void BetaCudaDeviceInterface::initialize(
196196

197197
TORCH_CHECK(avStream != nullptr, "AVStream cannot be null");
198198
timeBase_ = avStream->time_base;
199+
frameRateAvgFromFFmpeg_ = avStream->r_frame_rate;
199200

200201
const AVCodecParameters* codecPar = avStream->codecpar;
201202
TORCH_CHECK(codecPar != nullptr, "CodecParameters cannot be null");

test/test_decoders.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1529,7 +1529,10 @@ def test_beta_cuda_interface_get_frame_played_at(self, asset, seek_mode):
15291529
for pts in timestamps:
15301530
ref_frame = ref_decoder.get_frame_played_at(pts)
15311531
beta_frame = beta_decoder.get_frame_played_at(pts)
1532-
torch.testing.assert_close(beta_frame.data, ref_frame.data, rtol=0, atol=0)
1532+
if get_ffmpeg_major_version() > 4: # TODONVDEC P1 see above
1533+
torch.testing.assert_close(
1534+
beta_frame.data, ref_frame.data, rtol=0, atol=0
1535+
)
15331536

15341537
assert beta_frame.pts_seconds == ref_frame.pts_seconds
15351538
assert beta_frame.duration_seconds == ref_frame.duration_seconds
@@ -1563,7 +1566,10 @@ def test_beta_cuda_interface_get_frames_played_at(self, asset, seek_mode):
15631566

15641567
ref_frames = ref_decoder.get_frames_played_at(timestamps)
15651568
beta_frames = beta_decoder.get_frames_played_at(timestamps)
1566-
torch.testing.assert_close(beta_frames.data, ref_frames.data, rtol=0, atol=0)
1569+
if get_ffmpeg_major_version() > 4: # TODONVDEC P1 see above
1570+
torch.testing.assert_close(
1571+
beta_frames.data, ref_frames.data, rtol=0, atol=0
1572+
)
15671573
torch.testing.assert_close(beta_frames.pts_seconds, ref_frames.pts_seconds)
15681574
torch.testing.assert_close(
15691575
beta_frames.duration_seconds, ref_frames.duration_seconds
@@ -1602,7 +1608,10 @@ def test_beta_cuda_interface_backwards(self, asset, seek_mode):
16021608

16031609
ref_frame = ref_decoder.get_frame_at(frame_index)
16041610
beta_frame = beta_decoder.get_frame_at(frame_index)
1605-
torch.testing.assert_close(beta_frame.data, ref_frame.data, rtol=0, atol=0)
1611+
if get_ffmpeg_major_version() > 4: # TODONVDEC P1 see above
1612+
torch.testing.assert_close(
1613+
beta_frame.data, ref_frame.data, rtol=0, atol=0
1614+
)
16061615

16071616
assert beta_frame.pts_seconds == ref_frame.pts_seconds
16081617
assert beta_frame.duration_seconds == ref_frame.duration_seconds

0 commit comments

Comments
 (0)