str cast, docs update, [], remove 'in' from test

Author: Dan-Flores

src/torchcodec/encoders/_video_encoder.py

@@ -74,7 +74,7 @@ def to_file(
             crf=crf,
             preset=preset,
             extra_options=[
-                x for k, v in (extra_options or {}).items() for x in (k, str(v))
+                str(x) for k, v in (extra_options or {}).items() for x in (k, v)
             ],
         )
 
@@ -106,7 +106,7 @@ def to_tensor(
                 a string: "fast", "medium", "slow"). Defaults to None
                 (which will use encoder's default).
             extra_options (dict[str, Any], optional): A dictionary of additional
-                encoder options to pass, e.g. ``{"preset": "slow", "tune": "film"}``.
+                encoder options to pass, e.g. ``{"qp": 5, "tune": "film"}``.
                 Values will be converted to strings before passing to the encoder.
 
         Returns:
@@ -122,7 +122,7 @@ def to_tensor(
             crf=crf,
             preset=preset_value,
             extra_options=[
-                x for k, v in (extra_options or {}).items() for x in (k, str(v))
+                str(x) for k, v in (extra_options or {}).items() for x in (k, v)
             ],
         )
 
@@ -160,7 +160,7 @@ def to_file_like(
                 a string: "fast", "medium", "slow"). Defaults to None
                 (which will use encoder's default).
             extra_options (dict[str, Any], optional): A dictionary of additional
-                encoder options to pass, e.g. ``{"preset": "slow", "tune": "film"}``.
+                encoder options to pass, e.g. ``{"qp": 5, "tune": "film"}``.
                 Values will be converted to strings before passing to the encoder.
         """
         preset = str(preset) if isinstance(preset, int) else preset
@@ -174,6 +174,6 @@ def to_file_like(
             crf=crf,
             preset=preset,
             extra_options=[
-                x for k, v in (extra_options or {}).items() for x in (k, str(v))
+                str(x) for k, v in (extra_options or {}).items() for x in (k, v)
             ],
         )

test/test_encoders.py

@@ -1092,9 +1092,9 @@ def test_codec_parameter_utilized(self, tmp_path, format, codec_spec):
         dest = str(tmp_path / f"output.{format}")
 
         VideoEncoder(frames=frames, frame_rate=30).to_file(dest=dest, codec=codec_spec)
-        actual_codec_spec = self._get_video_metadata(dest, fields=["codec_name"]).get(
+        actual_codec_spec = self._get_video_metadata(dest, fields=["codec_name"])[
             "codec_name"
-        )
+        ]
         assert actual_codec_spec == codec_spec
 
     @pytest.mark.skipif(
@@ -1131,15 +1131,11 @@ def test_codec_spec_vs_impl_equivalence(self, tmp_path, codec_spec, codec_impl):
         )
 
         assert (
-            self._get_video_metadata(spec_output, fields=["codec_name"]).get(
-                "codec_name"
-            )
+            self._get_video_metadata(spec_output, fields=["codec_name"])["codec_name"]
             == codec_spec
         )
         assert (
-            self._get_video_metadata(impl_output, fields=["codec_name"]).get(
-                "codec_name"
-            )
+            self._get_video_metadata(impl_output, fields=["codec_name"])["codec_name"]
             == codec_spec
         )
 
@@ -1175,6 +1171,7 @@ def test_extra_options_utilized(self, tmp_path, profile, colorspace, color_range
             fields=["profile", "color_space", "color_range"],
         )
         # Validate profile (case-insensitive, baseline is reported as "Constrained Baseline")
-        assert profile in metadata.get("profile", "").lower()
-        assert metadata.get("color_space") == colorspace
-        assert metadata.get("color_range") == color_range
+        expected_profile = "constrained baseline" if profile == "baseline" else profile
+        assert metadata["profile"].lower() == expected_profile
+        assert metadata["color_space"] == colorspace
+        assert metadata["color_range"] == color_range