From 009c85b377c7b2c5211a676753346ac2a545c62c Mon Sep 17 00:00:00 2001 From: Ahmad Sharif Date: Mon, 28 Oct 2024 08:23:42 -0700 Subject: [PATCH 1/2] Relax test constraint for ffmpeg versions as they can be arbitrary --- test/decoders/test_video_decoder_ops.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/decoders/test_video_decoder_ops.py b/test/decoders/test_video_decoder_ops.py index d7291c304..74de8348c 100644 --- a/test/decoders/test_video_decoder_ops.py +++ b/test/decoders/test_video_decoder_ops.py @@ -423,9 +423,7 @@ def test_get_ffmpeg_version(self): # The earliest libavutil version is 50 as per: # https://www.ffmpeg.org/olddownload.html assert ffmpeg_dict["libavutil"][0] > 50 - ffmpeg_version = ffmpeg_dict["ffmpeg_version"] - split_ffmpeg_version = [int(num) for num in ffmpeg_version.split(".")] - assert len(split_ffmpeg_version) == 3 + assert "ffmpeg_version" in ffmpeg_dict def test_frame_pts_equality(self): decoder = create_from_file(str(NASA_VIDEO.path)) From 7209854c4386ed833a697d8f007cb7fee9bdf361 Mon Sep 17 00:00:00 2001 From: Ahmad Sharif Date: Mon, 28 Oct 2024 08:26:29 -0700 Subject: [PATCH 2/2] . --- .github/workflows/linux_cuda_wheel.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/linux_cuda_wheel.yaml b/.github/workflows/linux_cuda_wheel.yaml index 3e721ee26..842013ec6 100644 --- a/.github/workflows/linux_cuda_wheel.yaml +++ b/.github/workflows/linux_cuda_wheel.yaml @@ -135,8 +135,7 @@ jobs: ${CONDA_RUN} python test/decoders/manual_smoke_test.py - name: Run Python tests run: | - # We skip test_get_ffmpeg_version because it may not have a micro version. - ${CONDA_RUN} FAIL_WITHOUT_CUDA=1 pytest test -k "not test_get_ffmpeg_version" -vvv + ${CONDA_RUN} FAIL_WITHOUT_CUDA=1 pytest test -vvv - name: Run Python benchmark run: | ${CONDA_RUN} time python benchmarks/decoders/gpu_benchmark.py --devices=cuda:0,cpu --resize_devices=none