Added proper tensor support for get_frames_played_at() #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Modified get_frames_played_at in _video_decoder to accept tensors and updated all downstream functions to natively accept tensors rather than converting them to lists. Test Plan: Reviewers: Subscribers: Tasks: Tags:
meta-cla
bot
added
the
CLA Signed
NicolasHug
reviewed
Oct 6, 2025
Contributor
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @mollyxu - this looks great, I do have a question about the Exception catching below. LMK your thoughts!
Contributor
|
To ensure we do not break this functionality in the future, we could add a test case to test_get_frames_played_at, where we pass in a tensor and ensure the outputs are what we expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Modified get_frames_played_at in _video_decoder to accept tensors and updated all downstream functions to natively accept tensors rather than converting them to lists.