Skip to content

Mark slow tests #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotts merged 2 commits into from
Oct 16, 2025
Merged

Mark slow tests #968

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d74e8d0
Mark slow tests
scotts Oct 15, 2025
ee000a8
Just mark webm
scotts Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,6 +1384,7 @@ def decode(self, file_path) -> torch.Tensor:
frames, *_ = get_frames_in_range(decoder, start=0, stop=60)
return frames

@pytest.mark.slow
@pytest.mark.parametrize("format", ("mov", "mp4", "mkv", "webm"))
Copy link
Contributor

@NicolasHug NicolasHug Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can "mark" individual entries with arbitrary marks:

Suggested change
@pytest.mark.slow
@pytest.mark.parametrize("format", ("mov", "mp4", "mkv", "webm"))
@pytest.mark.parametrize(
"format", ("mov", "mp4", "mkv", pytest.param("webm", marks=pytest.mark.slow))
)

This is also how we handle our automatic "needs_cuda" mark:

torchcodec/test/utils.py

Lines 29 to 34 in b9cf8d1

def all_supported_devices():
return (
"cpu",
pytest.param("cuda", marks=pytest.mark.needs_cuda),
pytest.param("cuda:0:beta", marks=pytest.mark.needs_cuda),
)

def test_video_encoder_round_trip(self, tmp_path, format):
# Test that decode(encode(decode(asset))) == decode(asset)
Expand Down Expand Up @@ -1422,6 +1423,7 @@ def test_video_encoder_round_trip(self, tmp_path, format):
assert psnr(s_frame, rt_frame) > 30
assert_close(s_frame, rt_frame, atol=atol, rtol=0)

@pytest.mark.slow
@pytest.mark.skipif(in_fbcode(), reason="ffmpeg CLI not available")
@pytest.mark.parametrize(
"format", ("mov", "mp4", "avi", "mkv", "webm", "flv", "gif")
Copy link
Contributor

@NicolasHug NicolasHug Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Expand Down
Loading