Check return value of cudaSetDevice #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
commented
Oct 17, 2025
| cudaSetDevice(deviceIndex); | ||
| TORCH_CHECK( | ||
| cudaSetDevice(deviceIndex) == cudaSuccess, "Failed to set CUDA device"); | ||
| AVBufferRef* hardwareDeviceCtxRaw = nullptr; |
Contributor
Author
There was a problem hiding this comment.
Drive-by: I removed the comment above because it's now out of place, the deviceIndex was set to a proper value just above (currently line 54)
Separately, I'm not even sure we need the deviceGuard and the call to cudaSetDevice. I we should rely on PyTorch for that kind of stuff. Maybe it'll be worth revisiting in the future, for now, it's safe to keep as-is.
Dan-Flores
approved these changes
Oct 17, 2025
NicolasHug
added a commit
to NicolasHug/torchcodec
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an internal lint warning.