Fix F14Map warning at oss build

Summary:
See title.

Before fix, we see many of the following warning in NCCL OSS build:
```
warning: ‘std::enable_if_t<(! folly::Conjunction<std::is_nothrow_move_constructible<T>, std::is_nothrow_destructible<_Up> >::value)> folly::f14::detail::VectorContainerPolicy<Key, MappedTypeOrVoid, HasherOrVoid, KeyEqualOrVoid, AllocOrVoid, EligibleForPerturbedInsertionOrder>::complainUnlessNothrowMoveAndDestroy() [with T = std::deque<std::unique_ptr<PendingOp> >; Key = int; MappedTypeOrVoid = std::deque<std::unique_ptr<PendingOp> >; HasherOrVoid = void; KeyEqualOrVoid = void; AllocOrVoid = void; EligibleForPerturbedInsertionOrder = std::integral_constant<bool, true>; std::enable_if_t<(! folly::Conjunction<std::is_nothrow_move_constructible<T>, std::is_nothrow_destructible<_Up> >::value)> = void]’ is deprecated: mark {key_type,mapped_type} {move constructor,destructor} noexcept, or use F14Node* if they aren't"
```

Example: https://www.internalfb.com/sandcastle/workflow/2783224569726899686/artifact/actionlog.2783224569921182489.stdout.1?selectedLines=19953-19953-56-877

This patch fixes it

Reviewed By: elvinlife

Differential Revision: D87721250

fbshipit-source-id: b235af7d1ca737bc2e17cd92700f6329210d7000

Author: minsii

comms/ctran/backends/ib/CtranIb.h

@@ -655,9 +655,9 @@ class CtranIb {
         if (it == rankToPendingOpsMap.end()) {
           // create a new entry for the peer if it does not exist and VC is not
           // established
-          rankToPendingOpsMap[peerRank].push_back(std::move(pendingOp));
+          rankToPendingOpsMap[peerRank].q.push_back(std::move(pendingOp));
         } else {
-          it->second.push_back(std::move(pendingOp));
+          it->second.q.push_back(std::move(pendingOp));
         }
         pending = true;
       }
@@ -686,7 +686,7 @@ class CtranIb {
         // If VC has established, move the pendingOps list to readyToIssueOps;
         // otherwise, skip and move to next peer.
         if (vc) {
-          for (auto& op : it->second) {
+          for (auto& op : it->second.q) {
             readyToIssueOps[peerRank].push_back(std::move(op));
           }
           // Remove the peer entry once all pending ops are issued.
@@ -1116,8 +1116,15 @@ class CtranIb {
   std::unique_ptr<::ctran::ib::LocalVirtualConn> localVc;
   std::mutex localVcMutex;
 
-  folly::F14FastMap<int, std::deque<std::unique_ptr<PendingOp>>>
-      rankToPendingOpsMap;
+  struct PendingOpQueue {
+    std::deque<std::unique_ptr<PendingOp>> q;
+    PendingOpQueue() = default;
+    PendingOpQueue(const PendingOpQueue&) noexcept = default;
+    PendingOpQueue(PendingOpQueue&&) noexcept = default;
+    ~PendingOpQueue() noexcept = default;
+  };
+
+  folly::F14FastMap<int, PendingOpQueue> rankToPendingOpsMap;
   std::mutex pendingOpsMutex;
 
   CtranCtrlManager* ctrlMgr{nullptr};

comms/ctran/backends/socket/CtranSocket.cc

@@ -335,10 +335,10 @@ bool CtranSocket::addToPendingOpsIfRequired(
 
       if (it == locked->end()) {
         // if there's no socket and no pendingops queue, create a queue
-        locked->emplace(peerRank, std::deque<std::unique_ptr<SockPendingOp>>());
-        locked->at(peerRank).push_back(std::move(pendingOp));
+        auto res = locked->emplace(peerRank, PendingOpQueue());
+        res.first->second.q.push_back(std::move(pendingOp));
       } else {
-        it->second.push_back(std::move(pendingOp));
+        it->second.q.push_back(std::move(pendingOp));
       }
       pending = true;
     }
@@ -367,7 +367,7 @@ commResult_t CtranSocket::progressPendingOps(void) {
       // If Socket has established, move the pendingOps list to
       // readyToIssueOps; otherwise, skip and move to next peer.
       if (sock) {
-        for (auto& op : it->second) {
+        for (auto& op : it->second.q) {
           readyToIssueOps[peerRank].push_back(std::move(op));
         }
         // Remove the peer entry once all pending ops are issued.

comms/ctran/backends/socket/CtranSocket.h

@@ -96,6 +96,11 @@ class CtranSocket {
   struct recvCtrlQueue {
     std::deque<std::unique_ptr<SockPendingOp>> postedOps_;
     std::deque<std::unique_ptr<ControlMsg>> unexpMsgs_;
+
+    recvCtrlQueue() = default;
+    recvCtrlQueue(recvCtrlQueue&& other) noexcept = default;
+    recvCtrlQueue(const recvCtrlQueue& other) = default;
+    ~recvCtrlQueue() noexcept = default;
   };
 
   void init(const SocketServerAddr& serverAddr);
@@ -170,12 +175,9 @@ class CtranSocket {
   }
 
   inline recvCtrlQueue& getRecvCtrlQueue(int peerRank) {
-    auto it = rankToRecvCtrlMap_.find(peerRank);
-    if (it == rankToRecvCtrlMap_.end()) {
-      rankToRecvCtrlMap_[peerRank] = recvCtrlQueue();
-    }
-    auto& recvQueue = rankToRecvCtrlMap_[peerRank];
-    return recvQueue;
+    auto [it, inserted] =
+        rankToRecvCtrlMap_.try_emplace(peerRank, recvCtrlQueue());
+    return it->second;
   }
 
   const int rank_;
@@ -198,8 +200,16 @@ class CtranSocket {
   // the rankToSocket is accessed by both the main thread and the listen thread.
   folly::Synchronized<SocketMaps> socketMaps_;
 
-  folly::Synchronized<
-      folly::F14FastMap<int, std::deque<std::unique_ptr<SockPendingOp>>>>
+  struct PendingOpQueue {
+    std::deque<std::unique_ptr<SockPendingOp>> q;
+
+    PendingOpQueue() = default;
+    PendingOpQueue(const PendingOpQueue&) noexcept = default;
+    PendingOpQueue(PendingOpQueue&&) noexcept = default;
+    ~PendingOpQueue() noexcept = default;
+  };
+
+  folly::Synchronized<folly::F14FastMap<int, PendingOpQueue>>
       rankToPendingOpsMap_;
 
   // every rank maintains a postedrecv queue and unexpected msg queue