Skip to content

Commit 1f74869

Browse files
felipemello1Felipe Mello
andauthored
reduce batch size and renable perf tracker (#278)
Co-authored-by: Felipe Mello <[email protected]>
1 parent 21c7444 commit 1f74869

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

apps/grpo/qwen3_8b.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
# Global configuration
55
group_size: 8
66
batch_size: 16
7-
max_req_tokens: 512
8-
max_res_tokens: 512
7+
max_req_tokens: 468
8+
max_res_tokens: 468
99
model: "Qwen/Qwen3-8B"
1010
off_by_n: 1 # Off by one by default
1111

src/forge/observability/perf_tracker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def __init__(
106106

107107
self.prefix = prefix
108108
self.track_memory = track_memory
109-
self.time_with_gpu = False # timer == "gpu"
109+
self.time_with_gpu = timer == "gpu"
110110
self._disable = os.getenv(DISABLE_PERF_METRICS, "false") == "true"
111111
self._active = False
112112

@@ -297,7 +297,7 @@ def _compute_elapsed(start_event, end_event):
297297
index = len(self._futures)
298298
self._futures.append((name, future, index))
299299

300-
if len(self._futures) >= 20: # clean up every 20 to avoid memory leak
300+
if len(self._futures) >= 5: # clean up every 5
301301
self._collect_completed_futures()
302302

303303
self._chain_start = end_event

0 commit comments

Comments
 (0)