Skip to content

Commit 766319c

Browse files
author
Felipe Mello
committed
config
1 parent 7838dc4 commit 766319c

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

apps/sft/llama3_8b.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ metric_logging:
6161
project: sft-training
6262
group: sft_exp_${oc.env:USER}
6363
logging_mode: global_reduce # global_reduce, per_rank_reduce, per_rank_no_reduce
64-
per_rank_share_run: False
6564

6665
# profiling:
6766
# enable_profiling: false

apps/sft/qwen3_8b.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ activation_checkpoint:
5555
mode: selective
5656
selective_ac_option: op
5757

58+
metric_logging:
59+
wandb:
60+
project: sft-training
61+
group: sft_exp_${oc.env:USER}
62+
logging_mode: global_reduce # global_reduce, per_rank_reduce, per_rank_no_reduce
63+
5864
# profiling:
5965
# enable_profiling: false
6066

tests/unit_tests/datasets/test_iterable_utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ def generate_ckpt(
142142

143143

144144
def aggregate_metrics(metrics_list: list) -> dict[str, Any]:
145-
"""Aggregate metrics according to their reduction types (SUM, MEAN, MAX, MIN, STD)."""
146145
if not metrics_list:
147146
return {}
148147

0 commit comments

Comments
 (0)