run lint

Author: DNXie

apps/grpo/main.py

@@ -20,7 +20,7 @@
 )
 from forge.data.rewards import MathReward, ThinkingReward
 from forge.services.policy import Policy, PolicyConfig, SamplingOverrides, WorkerConfig
-from forge.services.reference_actor import compute_sequence_logprobs, TitanRefModel
+from forge.services.reference_service import compute_sequence_logprobs, TitanRefModel
 from forge.services.replay_buffer import ReplayBuffer
 from forge.util.metric_logging import get_metric_logger
 from monarch.actor import endpoint

src/forge/controller/service.py

@@ -9,11 +9,11 @@
 import math
 import sys
 
+from monarch.actor import Actor, current_rank, current_size, endpoint
+
 from forge.controller.proc_mesh import get_proc_mesh, stop_proc_mesh
 from forge.types import ProcessConfig
 
-from monarch.actor import Actor, current_rank, current_size, endpoint
-
 logger = logging.getLogger(__name__)
 logger.setLevel(logging.DEBUG)
 

src/forge/controller/service/replica.py

@@ -13,11 +13,11 @@
 from enum import Enum
 from typing import Optional
 
+from monarch.actor import ActorError
+
 from forge.controller import Service
 from forge.types import ProcessConfig
 
-from monarch.actor import ActorError
-
 logger = logging.getLogger(__name__)
 logger.setLevel(logging.DEBUG)
 

src/forge/controller/service/spawn.py

@@ -10,10 +10,11 @@
 
 from forge.controller import Service
 
+from monarch.actor import proc_mesh
+
 from forge.controller.service import Service, ServiceActor, ServiceConfig
 
 from forge.controller.service.interface import ServiceInterface, ServiceInterfaceV2
-from monarch.actor import proc_mesh
 
 logger = logging.getLogger(__name__)
 logger.setLevel(logging.INFO)

src/forge/interfaces.py

@@ -7,12 +7,12 @@
 from abc import ABC, abstractmethod
 from typing import Any, Mapping
 
+from monarch.actor import endpoint
+
 from forge.controller import Service
 
 from forge.types import Action, Message, Observation, Scalar, State
 
-from monarch.actor import endpoint
-
 
 class Transform(ABC):
     """Abstract base class for observation transforms.

src/forge/services/__init__.py

@@ -25,7 +25,7 @@ def __getattr__(name):
 
         return ReplayBuffer
     elif name == "TitanRefModel":
-        from .reference_actor import TitanRefModel
+        from .reference_service import TitanRefModel
 
         return TitanRefModel
     else:

src/forge/services/collector.py

@@ -12,14 +12,14 @@
 
 from typing import Callable
 
+from monarch.actor import Actor, endpoint
+
 from forge.interfaces import Policy
 
 from forge.services.replay_buffer import ReplayBuffer
 
 from forge.types import Trajectory
 
-from monarch.actor import Actor, endpoint
-
 
 class Collector(Actor):
     """Collects trajectories for the training loop."""

src/forge/services/policy.py

@@ -13,12 +13,6 @@
 from typing import Dict, List
 
 import torch
-
-from forge.controller import get_proc_mesh, Service, stop_proc_mesh
-
-from forge.data.sharding import VLLMSharding
-from forge.interfaces import Policy as PolicyInterface
-from forge.types import ProcessConfig
 from monarch.actor import current_rank, endpoint, ProcMesh
 from torchstore import MultiProcessStore
 from torchstore._state_dict_utils import DELIM
@@ -43,6 +37,12 @@
 from vllm.v1.structured_output import StructuredOutputManager
 from vllm.worker.worker_base import WorkerWrapperBase
 
+from forge.controller import get_proc_mesh, Service, stop_proc_mesh
+
+from forge.data.sharding import VLLMSharding
+from forge.interfaces import Policy as PolicyInterface
+from forge.types import ProcessConfig
+
 
 logger = logging.getLogger(__name__)
 

src/forge/services/reference_actor.py renamed to src/forge/services/reference_service.py

@@ -38,7 +38,7 @@
 @dataclass
 class TitanRefModel(Service):
     """
-    Represents a reference actor leveraging a torchtitan model for execution
+    Represents a reference service leveraging a torchtitan model for execution
 
     Intended for generating reference_logprobs - for example in KL Divergence
     """
@@ -155,7 +155,7 @@ def compute_logprobs(
 # Maintained to keep Old GRPO app prior to full migration off of HF
 class HuggingFaceRefModel(Service):
     """
-    Represents a reference actor leveraging HuggingFace for execution
+    Represents a reference service leveraging HuggingFace for execution
     """
 
     def __init__(self, model_name, device: torch.device | None = None):

src/forge/services/replay_buffer.py

@@ -8,10 +8,10 @@
 from dataclasses import dataclass
 from typing import Any
 
-from forge.controller import Service
-
 from monarch.actor import endpoint
 
+from forge.controller import Service
+
 
 @dataclass
 class ReplayBuffer(Service):