mroe clean

allenwang28 · allenwang28 · commit aa5367e77d30 · 2025-10-03T17:42:48.000-07:00
diff --git a/apps/grpo/main.py b/apps/grpo/main.py
@@ -320,7 +320,6 @@ async def main(cfg: DictConfig):
                 launcher_config=LauncherConfig(**cfg.provisioner.launcher)
             )
         )
-    # initialize before spawning services
     metric_logging_cfg = cfg.get("metric_logging", {"console": {"log_per_rank": False}})
     mlogger = await get_or_create_metric_logger()
     await mlogger.init_backends.call_one(metric_logging_cfg)

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,6 @@ async def main(cfg: DictConfig):`
`320`	`320`	`launcher_config=LauncherConfig(**cfg.provisioner.launcher)`
`321`	`321`	`)`
`322`	`322`	`)`
`323`		`- # initialize before spawning services`
`324`	`323`	`metric_logging_cfg = cfg.get("metric_logging", {"console": {"log_per_rank": False}})`
`325`	`324`	`mlogger = await get_or_create_metric_logger()`
`326`	`325`	`await mlogger.init_backends.call_one(metric_logging_cfg)`