Skip to content

Commit bd52608

Browse files
committed
Merge remote-tracking branch 'upstream/main' into temp-fix-sft
2 parents 32c9814 + b17bfeb commit bd52608

File tree

2 files changed

+6
-36
lines changed

2 files changed

+6
-36
lines changed

.github/ISSUE_TEMPLATE/feature-request.yml

Lines changed: 5 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -8,47 +8,17 @@ body:
88
#### Before submitting a feature request, please search through [existing issues](https://github.com/meta-pytorch/forge/issues?q=is%3Aissue+sort%3Acreated-desc+) to see if something similar has already been proposed.
99
- type: textarea
1010
attributes:
11-
label: 🎯 Context/Motivation
11+
label: Context/Motivation
1212
description: |
13-
Describe the problem you're trying to solve or the use case for this feature.
14-
What is the motivation behind this request? Why would this feature be valuable?
15-
placeholder: |
16-
Example: "When training large models, I often need to..."
13+
Describe the problem you're trying to solve or the use case for this feature. Include any relevant links and context.
1714
validations:
1815
required: true
1916
- type: textarea
2017
attributes:
21-
label: 💡 What does this look like in pseudo-code?
18+
label: Pseudo-code + acceptance criteria [Optional]
2219
description: |
23-
Provide a rough sketch of what the API or implementation might look like.
24-
This helps us understand your vision for how the feature would work.
25-
placeholder: |
26-
```python
27-
# Example pseudo-code showing how you envision using this feature
28-
model = MyModel()
29-
result = model.new_feature(...)
30-
```
31-
validations:
32-
required: false
33-
- type: textarea
34-
attributes:
35-
label: ✅ Acceptance Criteria
36-
description: |
37-
What would need to be true for this feature to be considered complete?
38-
List the key requirements or behaviors expected.
39-
placeholder: |
40-
- [ ] The feature should support X
41-
- [ ] It should handle edge case Y
42-
- [ ] Documentation is updated
43-
validations:
44-
required: true
45-
- type: textarea
46-
attributes:
47-
label: 📝 Additional Context
48-
description: |
49-
Add any other context, screenshots, examples, or references that would help explain the feature request.
50-
placeholder: |
51-
Links to similar implementations, research papers, or other relevant information.
20+
Provide a rough sketch of what the API or implementation might look like. This helps us understand your vision for how the feature would work.
21+
Also, if possible, include what would need to be true for this feature to be considered complete.
5222
validations:
5323
required: false
5424
- type: markdown

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[![Discord](https://img.shields.io/badge/Discord-OpenEnv-7289da?style=flat&logo=discord&logoColor=white)](https://discord.gg/YsTYBh6PD9)
77

88
## Overview
9-
The primary purpose of the torchforge ecosystem is to delineate infra concerns from model concerns thereby making RL experimentation easier. torchforge delivers this by providing clear RL abstractions and one scalable implementation of these abstractions. When you need fine-grained control over placement, fault handling/redirecting training loads during a run, or communication patterns, the primitives are there. When you don’t, you can focus purely on your RL algorithm.
9+
The primary purpose of the torchforge ecosystem is to separate infra concerns from model concerns thereby making RL experimentation easier. torchforge delivers this by providing clear RL abstractions and one scalable implementation of these abstractions. When you need fine-grained control over placement, fault handling/redirecting training loads during a run, or communication patterns, the primitives are there. When you don’t, you can focus purely on your RL algorithm.
1010

1111
Key features:
1212
- Usability for rapid research (isolating the RL loop from infrastructure)

0 commit comments

Comments
 (0)