Skip to content

Commit c0f4554

Browse files
authored
Updates all wheels and removes await (#272)
* update all wheels * no awaits * undo store/titan wheels
1 parent a3876e4 commit c0f4554

File tree

9 files changed

+9
-26
lines changed

9 files changed

+9
-26
lines changed
3.04 MB
Binary file not shown.

scripts/build_wheels.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ NC='\033[0m'
1717
# Configuration
1818
PYTORCH_VERSION="2.9.0.dev20250905"
1919
VLLM_BRANCH="v0.10.0"
20-
MONARCH_COMMIT="ce078ddbbac6b6f3682afd763d8d96dad8092a91"
20+
MONARCH_COMMIT="9c41b5c16edadeab7cfb8521ba7efe68a1e2bc87"
2121
TORCHTITAN_COMMIT="a3104201ba3a0fa19e9c3cc5ba748b0398551410"
2222
TORCHSTORE_COMMIT="0052f6d8b686b9cff0cf4ce203a836c4b5d5ac94"
2323
BUILD_DIR="$HOME/forge-build"

scripts/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ log_warning() { echo -e "${YELLOW}[WARNING]${NC} $1";}
2121
PYTORCH_VERSION="2.9.0.dev20250905"
2222
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
2323
WHEEL_DIR="$SCRIPT_DIR/../assets/wheels"
24-
RELEASE_TAG="v0.0.0-92025"
24+
RELEASE_TAG="v0.0.0-93025"
2525
GITHUB_REPO="meta-pytorch/forge"
2626

2727
# Check conda environment

src/forge/actors/policy.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ async def launch( # pyright: ignore[reportIncompatibleMethodOverride]
194194
vllm_config = engine_config.create_vllm_config()
195195
# TODO (felipemello): LocalFetcherActor doesnt spawn with this, so cannot
196196
# do logging within PolicyWorker
197-
workers = await worker_procs.spawn(
197+
workers = worker_procs.spawn(
198198
"vllm_worker", PolicyWorker, vllm_config=vllm_config, use_dcp=use_dcp
199199
)
200200

@@ -203,7 +203,7 @@ async def launch( # pyright: ignore[reportIncompatibleMethodOverride]
203203

204204
# TODO - expand support so name can stick within kwargs
205205
actor_name = kwargs.pop("name", cls.__name__)
206-
policy = await policy_proc.spawn(
206+
policy = policy_proc.spawn(
207207
actor_name,
208208
cls,
209209
engine_config=engine_config,

src/forge/controller/__init__.py

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,4 @@
66
from .actor import ForgeActor
77
from .proc_mesh import get_proc_mesh, stop_proc_mesh
88

9-
10-
# TODO - remove this once everything has moved to
11-
# service
12-
async def spawn_actors(
13-
name: str,
14-
actor_cls: ForgeActor,
15-
cfg,
16-
processes,
17-
set_address: bool = False,
18-
):
19-
"""Setup process Mesh and spawn Actors."""
20-
mesh = await get_proc_mesh(processes)
21-
actors = await mesh.spawn(name, actor_cls, **cfg)
22-
actors.mesh = mesh
23-
return actors
24-
25-
26-
__all__ = ["spawn_actors", "stop_proc_mesh", "get_proc_mesh", "ForgeActor"]
9+
__all__ = ["stop_proc_mesh", "get_proc_mesh", "ForgeActor"]

src/forge/controller/actor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ async def launch(cls, *args, **kwargs) -> "ForgeActor":
186186
proc_mesh = await get_proc_mesh(process_config=cfg)
187187

188188
actor_name = kwargs.pop("name", cls.__name__)
189-
actor = await proc_mesh.spawn(actor_name, cls, *args, **kwargs)
189+
actor = proc_mesh.spawn(actor_name, cls, *args, **kwargs)
190190
actor._proc_mesh = proc_mesh
191191

192192
if hasattr(proc_mesh, "_hostname") and hasattr(proc_mesh, "_port"):

src/forge/controller/provisioner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def bootstrap(gpu_ids: list[str]):
199199
per_host={"gpus": num_procs},
200200
bootstrap=functools.partial(bootstrap, gpu_ids=gpu_ids),
201201
)
202-
setup = await procs.spawn(f"setup-{uuid.uuid1()}", _SetupActor)
202+
setup = procs.spawn(f"setup-{uuid.uuid1()}", _SetupActor)
203203
# Pick a random host/port, we'll feed this in afterwards
204204
# Once we have true HostMesh support, we can do this on proc 0 of each host
205205
# then spin up the proc meshes with the environment afterwards.

src/forge/controller/service/spawn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ async def spawn_service_v2(
4141
# Create a single-node proc_mesh and actor_mesh for the Service Actor
4242
logger.info("Spawning Service Actor for %s", actor_def.__name__)
4343
m = await proc_mesh(gpus=1)
44-
service_actor = await m.spawn(
44+
service_actor = m.spawn(
4545
"service", ServiceActor, service_cfg, actor_def, actor_kwargs
4646
)
4747
await service_actor.__initialize__.call_one()

src/forge/observability/metric_actors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ async def get_or_create_metric_logger(
9797

9898
# Setup local_fetcher_actor if needed
9999
if not proc_has_local_fetcher:
100-
local_fetcher_actor = await proc.spawn(
100+
local_fetcher_actor = proc.spawn(
101101
"local_fetcher_actor", LocalFetcherActor, global_logger
102102
)
103103
await global_logger.register_fetcher.call_one(local_fetcher_actor, proc)

0 commit comments

Comments
 (0)