Skip to content

Commit d79aa65

Browse files
committed
Rebase cleanup
1 parent a29685d commit d79aa65

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/forge/actors/generator.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,11 @@ async def launch( # pyright: ignore[reportIncompatibleMethodOverride]
128128
) -> "Generator":
129129
"""Launch the Generator with its workers.
130130
131-
We overwrite the default Service launch method in order to setup Actors (PolicyWorker) within this "coordinating" Actor.
131+
We overwrite the default Service launch method in order to setup Actors (GeneratorWorker) within this "coordinating" Actor.
132132
We first create a proc_mesh for the workers, then a proc_mesh for the generator, and then we spawn the workers
133133
and the generator in setup.
134134
135-
The args here generally should match those in the `__init__` method of the Policy class.
135+
The args here generally should match those in the `__init__` method of the Generator class.
136136
"""
137137
# Note: get_proc_mesh will set MASTER_ADDR, MASTER_PORT and CUDA_VISIBLE_DEVICES
138138
process_config: ProcessConfig = ProcessConfig(
@@ -144,7 +144,7 @@ async def launch( # pyright: ignore[reportIncompatibleMethodOverride]
144144
worker_procs = await get_proc_mesh(process_config=process_config)
145145

146146
# TODO - issues/144 we will want to ensure colocation with workers
147-
# We're currently locating the Policy on the local host proc mesh
147+
# We're currently locating the Generator on the local host proc mesh
148148
# vLLM initialization without setting env variables at proc_mesh creation
149149
# level leads to issues.
150150
# Once we can create multiple proc meshes on a host mesh, we can ensure
@@ -492,7 +492,7 @@ def _extract_logprobs(self, sample: CompletionOutput) -> torch.Tensor | None:
492492

493493
@classmethod
494494
async def shutdown( # pyright: ignore[reportIncompatibleMethodOverride]
495-
cls: type["Policy"], actor: "Policy"
495+
cls: type["Generator"], actor: "Generator"
496496
):
497497
assert (
498498
actor._generator_proc is not None

0 commit comments

Comments
 (0)