Skip to content

Python version inconsistencies in Forge dependencies #291

@joecummings

Description

@joecummings

Problem

With this PR (pytorch/torchtitan#1778), TorchTitan upgraded their Python version to be only compatible with Python >= 3.12. It would appear this was an attempt to solve an issue in CI. We are now unable to install TorchTitan on Python < 3.12; we need TorchTitan for our model implementations / parallelisms.

Option 1: Upgrade everything to Python 3.12

Pros:

  • More modern version of Python
  • Less versions we have to test in CI / make guarantees about working

Cons:

  • Diverges with PyTorch's schedule of supported Python versions (they are set to drop 3.9 officially in 2.9 on Oct 15)
  • Forces all of our other dependencies to be upgraded to Python 3.12 (Monarch and TorchStore are mostly tested on Python 3.10), this could take a while to ensure these other dependencies work well

Option 2: Allow Python 3.10 in Monarch

Pros:

  • Operate as we did before, no additional changes needed
  • Titan stays in Python version schedule with PyTorch core

Cons:

  • CI might fail in Titan - do not fully understand the problem there and could use input from their team

I have a slight preference for Option 2, but very open to hearing thoughts from everyone.

cc @tianyu-l @wwwjn @allenwang28 @ebsmothers

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions