Leverage Services for Policy + Rename PolicyRouter #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
Code-wise this is pretty close to what we will be using Debugging an issue where |
Jack-Khuu
changed the title
joecummings
reviewed
Aug 26, 2025
src/forge/actors/policy.py
Outdated
| class Policy(PolicyInterface): | ||
| # TODO: Add dp support | ||
| policy: Actor | ||
| config: DictConfig |
There was a problem hiding this comment.
I don't like individual components having knowledge of our frontend config system. Can we parameterize this fully or pass in a policy specific config class?
allenwang28
reviewed
Aug 26, 2025
| await router.shutdown.call() | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
Can we move the policy main into its own app? apps/vllm.py or something
I think having a standalone vLLM application will be useful for Stanford too
There was a problem hiding this comment.
Totally let's do it in a. separate PR to unblock this one
Merged
|
lgtm, as long as it's running! |
allenwang28
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreation of #61, since commit history got borked
Leverage
spawn_servicesfor Policy and performs associated refactorsPolicyRouter->PolicyPolicy->PolicyWorker