skeleton code for torchstore integration of forge learner. #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pradeepfn
commented
Aug 29, 2025
pradeepfn
commented
- For initial feedback around.
- TODO items listed in the order of priority.
- Will add test script.
meta-cla
bot
added
the
CLA Signed
joecummings
reviewed
Aug 30, 2025
| self._size = math.prod(current_size().values()) | ||
|
|
||
| # init torchstore | ||
| self._tstore = asyncio.run(MultiProcessStore.create_store()) |
There was a problem hiding this comment.
Do you need the asyncio.run?
There was a problem hiding this comment.
Do you need the asyncio.run?
This is because __init__ is not async?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.